Re: [PATCH 01/16] fix default __strnlen_user macro

Mark Salter
2011-05-13T14:41:03Z

On Fri, 2011-05-13 at 13:55 +0000, Pavel Machek wrote:
> > The existing __strnlen_user macro simply resolved to strnlen. However, the
> > count returned by strnlen_user should include the NULL byte. This patch
> > fixes the __strnlen_user macro to include the NULL byte in the count.
>
> Are you sure? Having strnlen and _foo_strnlen with different return
> values seems very very dangerous.
>

Yes. I am sure based on comments and usage elsewhere in the kernel.
That difference certainly through me off track as I tried to figure out
why my kernels failed to mount roots when I switched to the generic
uaccess.h.

--Mark