From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Anuj Aggarwal <anuj.aggarwal@ti.com>,
Graeme Gregory <gg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: Fix desc_id for tps65023/6507x/65910
Date: Fri, 13 May 2011 13:34:52 +0100 [thread overview]
Message-ID: <1305290092.3202.6.camel@odin> (raw)
In-Reply-To: <1305179270.11113.3.camel@phoenix>
On Thu, 2011-05-12 at 13:47 +0800, Axel Lin wrote:
> The desc_id variable should not be a static variable.
>
> The rest of the code assumes the desc_id must less than TPSxxxxx_NUM_REGULATOR.
> If we set desc_id to be a static variable, checking the return value of
> rdev_get_id() may return error.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Anuj Aggarwal <anuj.aggarwal@ti.com>
> Cc: Graeme Gregory <gg@slimlogic.co.uk>
Applied.
Liam
prev parent reply other threads:[~2011-05-13 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 5:47 [PATCH] regulator: Fix desc_id for tps65023/6507x/65910 Axel Lin
2011-05-12 6:30 ` Mark Brown
2011-05-13 12:34 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305290092.3202.6.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=anuj.aggarwal@ti.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox