* [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c_write
@ 2011-05-16 14:19 Axel Lin
2011-05-16 20:19 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-05-16 14:19 UTC (permalink / raw)
To: linux-kernel
Cc: Graeme Gregory, Jorge Eduardo Candelaria, Samuel Ortiz,
Liam Girdwood
If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/tps65910.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index bf649cf..e318248 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
u8 msg[TPS65910_MAX_REGISTER + 1];
int ret;
- if (bytes > (TPS65910_MAX_REGISTER + 1))
+ if (bytes > TPS65910_MAX_REGISTER)
return -EINVAL;
msg[0] = reg;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c_write
2011-05-16 14:19 [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c_write Axel Lin
@ 2011-05-16 20:19 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-05-16 20:19 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Graeme Gregory, Jorge Eduardo Candelaria,
Samuel Ortiz
On Mon, 2011-05-16 at 22:19 +0800, Axel Lin wrote:
> If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
> doing memcpy(&msg[1], src, bytes).
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/tps65910.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index bf649cf..e318248 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
> u8 msg[TPS65910_MAX_REGISTER + 1];
> int ret;
>
> - if (bytes > (TPS65910_MAX_REGISTER + 1))
> + if (bytes > TPS65910_MAX_REGISTER)
> return -EINVAL;
>
> msg[0] = reg;
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-16 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-16 14:19 [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c_write Axel Lin
2011-05-16 20:19 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox