Re: [PATCH RESEND] mfd: Fix off-by-one value range checking for tps65910_i2c_write

Liam Girdwood
2011-05-16T20:19:15Z

On Mon, 2011-05-16 at 22:19 +0800, Axel Lin wrote:
> If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
> doing memcpy(&msg[1], src, bytes).
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
> ---
> drivers/mfd/tps65910.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index bf649cf..e318248 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
> u8 msg[TPS65910_MAX_REGISTER + 1];
> int ret;
>
> - if (bytes > (TPS65910_MAX_REGISTER + 1))
> + if (bytes > TPS65910_MAX_REGISTER)
> return -EINVAL;
>
> msg[0] = reg;

Applied.