linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: tytso@mit.edu, mina86@mina86.com, jirislaby@gmail.com,
	kosaki.motohiro@jp.fujitsu.com, rientjes@google.com,
	dave@linux.vne, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] v4 Improve task->comm locking situation
Date: Tue, 17 May 2011 21:15:09 -0700	[thread overview]
Message-ID: <1305692109.2915.139.camel@work-vm> (raw)
In-Reply-To: <201105180316.p4I3G6f2094560@www262.sakura.ne.jp>

On Wed, 2011-05-18 at 12:16 +0900, Tetsuo Handa wrote:
> What about replacing
> 	char comm[TASK_COMM_LEN];
> with
> 	char *rcu_commname;
> and switching it atomically using RCU?

So I think this approach is definitely worth trying. However, I think
converting to RCU will be much easier once we've first converted all
current comm users to making use of the get_task_comm accessor
functions. In this way my hope is my current proposal will serve as a
cleanup step before further optimizations can be done.

thanks
-john



  parent reply	other threads:[~2011-05-18  4:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 21:19 [PATCH 0/3] v4 Improve task->comm locking situation John Stultz
2011-05-16 21:19 ` [PATCH 1/3] comm: Introduce comm_lock seqlock to protect task->comm access John Stultz
2011-05-16 22:01   ` Jiri Slaby
2011-05-17  1:47     ` John Stultz
2011-05-18  0:28   ` KOSAKI Motohiro
2011-05-16 21:19 ` [PATCH 2/3] printk: Add %ptc to safely print a task's comm John Stultz
2011-05-16 21:54   ` Jiri Slaby
2011-05-16 23:10     ` John Stultz
2011-05-16 23:56       ` Joe Perches
2011-05-17  0:11         ` John Stultz
2011-05-17  7:21         ` Jiri Slaby
2011-05-18  0:32   ` KOSAKI Motohiro
2011-05-16 21:19 ` [PATCH 3/3] checkpatch.pl: Add check for task comm references John Stultz
2011-05-16 21:29   ` Michal Nazarewicz
2011-05-16 21:34     ` David Rientjes
2011-05-16 23:04       ` Joe Perches
2011-05-16 23:11         ` Michal Nazarewicz
2011-05-16 23:22           ` Joe Perches
2011-05-18  3:16 ` [PATCH 0/3] v4 Improve task->comm locking situation Tetsuo Handa
2011-05-18  4:10   ` KOSAKI Motohiro
2011-05-18  4:15   ` John Stultz [this message]
2011-05-18  5:27     ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305692109.2915.139.camel@work-vm \
    --to=john.stultz@linaro.org \
    --cc=dave@linux.vne \
    --cc=jirislaby@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mina86@mina86.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rientjes@google.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).