From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hillf Danton <dhillf@gmail.com>,
Yong Zhang <yong.zhang0@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] sched: correct how RT task is picked
Date: Wed, 18 May 2011 17:20:47 +0200 [thread overview]
Message-ID: <1305732047.2466.7176.camel@twins> (raw)
In-Reply-To: <1305731754.11267.3.camel@gandalf.stny.rr.com>
On Wed, 2011-05-18 at 11:15 -0400, Steven Rostedt wrote:
> On Wed, 2011-05-18 at 22:46 +0800, Hillf Danton wrote:
>
> > For migration, it is the case that cpu != rq->cpu, and
> > if cpu is allowed by task's affinity, it is bug that task
> > could not goto cpu because of nr_cpus_allowed since
> > the nr_cpus_allowed is computed based on the cpus_allowed mask.
>
> Right, that nr_cpus_allowed was to be a short cut, so we did not have to
> look at the cpu mask. But as that check came after, it was pointless.
> Perhaps that too was a relic with the cpu < 0 case.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
Hillf could you send a final patch with a proper changelog and Steven's
ack? From what I can see the latest patch is burried somewhere in this
discussion thread and is without changelog.
next prev parent reply other threads:[~2011-05-18 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 13:04 [PATCH] sched: correct how RT task is picked Hillf Danton
2011-05-11 8:43 ` Yong Zhang
2011-05-11 13:44 ` Hillf Danton
2011-05-12 12:06 ` Yong Zhang
2011-05-18 1:38 ` Steven Rostedt
2011-05-18 2:31 ` Yong Zhang
2011-05-18 13:19 ` Hillf Danton
2011-05-18 13:24 ` Steven Rostedt
2011-05-18 14:46 ` Hillf Danton
2011-05-18 15:15 ` Steven Rostedt
2011-05-18 15:20 ` Peter Zijlstra [this message]
2011-05-19 12:49 ` [PATCH resend] " Hillf Danton
2011-05-19 1:41 ` [PATCH] " Yong Zhang
2011-05-19 1:44 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305732047.2466.7176.camel@twins \
--to=peterz@infradead.org \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox