From: anish <anish198519851985@gmail.com>
To: apw@canonical.com, greg@kroah.com, man.k1983@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: PATCH] patch to generate warning when signed-of line in patch in not proper
Date: Thu, 19 May 2011 22:53:29 +0530 [thread overview]
Message-ID: <1305825809.2336.110.camel@anish-desktop> (raw)
From: anish kumar <anish198519851985@gmail.com>
This patch generates warning when there is no space between the
patch submitter name and successive mail-id.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
scripts/checkpatch.pl | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..437c6d4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1373,10 +1373,16 @@ sub process {
WARN("Signed-off-by: is the preferred form\n" .
$herecurr);
}
- if ($line =~ /^\s*signed-off-by:\S/i) {
- WARN("space required after Signed-off-by:\n" .
+ if ($line =~ /^\s*signed-off-by:(.*)/i) {
+ if($1 !~ /^(\s[a-zA-Z].*)/i) {
+ WARN("Space required after Signed-off-by:\n" .
$herecurr);
}
+ if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {
+ WARN("Space required between Full Name & Mail-id:\n" .
+ $herecurr);
+ }
+ }
}
# Check for wrappage within a valid hunk of the file
--
1.7.0.4
next reply other threads:[~2011-05-19 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 17:23 anish [this message]
[not found] ` <BANLkTik2NVHNbG4mSZDWJ2Mt5i6AhGr+uw@mail.gmail.com>
2011-05-21 16:03 ` PATCH] patch to generate warning when signed-of line in patch in not proper Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2011-05-21 19:38 anish
2011-05-21 19:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305825809.2336.110.camel@anish-desktop \
--to=anish198519851985@gmail.com \
--cc=apw@canonical.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=man.k1983@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox