From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Stephane Eranian <eranian@google.com>
Subject: [PATCH 2/6] perf tools: Remove junk code in mmap size handling
Date: Sun, 22 May 2011 03:45:40 +0200 [thread overview]
Message-ID: <1306028744-10603-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1306028744-10603-1-git-send-email-fweisbec@gmail.com>
size is overriden later and used only then. Those
lines are only junk, probably a leftover.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>
---
tools/perf/util/session.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 61746b5..db65206 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1018,9 +1018,6 @@ more:
if (session->header.needs_swap)
perf_event_header__bswap(&event->header);
- size = event->header.size;
- if (size == 0)
- size = 8;
if (head + event->header.size > mmap_size) {
if (mmaps[map_idx]) {
--
1.7.3.2
next prev parent reply other threads:[~2011-05-22 1:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 1:45 [GIT PULL] perf tools updates Frederic Weisbecker
2011-05-22 1:45 ` [PATCH 1/6] perf tools: Check we are able to read the event size on mmap Frederic Weisbecker
2011-05-22 1:45 ` Frederic Weisbecker [this message]
2011-05-22 1:45 ` [PATCH 4/6] perf tools: Pre-check sample size before parsing Frederic Weisbecker
2011-05-22 1:45 ` [PATCH 5/6] perf tools: Robustify dynamic sample content fetch Frederic Weisbecker
2011-05-22 1:45 ` [PATCH 6/6] perf tools: Propagate event parse error handling Frederic Weisbecker
2011-05-22 8:49 ` [GIT PULL] perf tools updates Ingo Molnar
2011-05-22 12:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306028744-10603-3-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).