From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbdB1Muj (ORCPT ); Tue, 28 Feb 2017 07:50:39 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:49284 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752060AbdB1MuV (ORCPT ); Tue, 28 Feb 2017 07:50:21 -0500 X-AuditID: b6c32a58-f79f16d00000132c-93-58b56050eddf From: Bartlomiej Zolnierkiewicz To: Mark Brown Cc: Krzysztof Kozlowski , Lee Jones , Chanwoo Choi , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [RFT 0/4] mfd: regulator: max14577: Remove support for platform data Date: Tue, 28 Feb 2017 12:34:37 +0100 Message-id: <13060664.SiaA6008Pk@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170228094740.kgsanxtum6xj2wdt@sirena.org.uk> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42LZdlhTUzcgYWuEQdsvaYupD5+wWVz/8pzV 4vz5DewW978eZbT4dqWDyeLyrjlsDmweO2fdZffYtKqTzePOtT1sHn1bVjF6fN4kF8AaxWWT kpqTWZZapG+XwJXRtUy14DVXxe4OnQbGExxdjBwcEgImEif+1XUxcgKZYhIX7q1n62Lk4hAS WMoo0Xl7FhOE084k8f7YDxaIKhOJ2bNWMkMkljNKdB8/ygrhfGWUWLOslxGkik3ASmJi+yow W0RAWeLq970sIEXMAjsYJc6cO8IGkhAWCJZoWNsNNpZFQFVi3Y6XrCA2r4CWxJ9lJ8BqRAW8 JLbsa2cCsTkFbCQOL7kMVSMo8WPyPbBeZgF5iX37p7JC2DoSZ4+tYwRZJiGwiF3i+KqJzBCP ykpsOsAM8YKLxKtlK5ggbGGJV8e3sEPY0hJ/l95ihLCnM0ps/y0BMWczo8Sq3ROgiqwlDh+/ CLWMT6L39xMmiPm8Eh1tQhAlHhLnVz9hhbAdJdYfWgANofWMEiePTWKcwCg/C8kPs5D8MAvJ DwsYmVcxiqUWFOempxabFpjoFSfmFpfmpesl5+duYgQnEq2IHYz/ZgQdYhTgYFTi4dVg2xoh xJpYVlyZe4hRgoNZSYS3IxwoxJuSWFmVWpQfX1Sak1p8iFGag0VJnDfKYGKEkEB6Yklqdmpq QWoRTJaJg1OqgZF/68tsjej1lhHnfRqm2AcW6Juecvz+slbC5fivHSLLBW3FF/YceHvMPE9r +ZSnmxty72XemPXPWYaxcM9tUf+PfR9b175itVcNanFbFZss8JCdrU6V+9tezS0b+3W1Xh94 sjdx3Wq9jSefTFl8oG4259Ur3uel9PIP6xxeyL3oZqpRsKrXqSglluKMREMt5qLiRAAY94xo IAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t9jAV3/hK0RBlu/6VtMffiEzeL6l+es FufPb2C3uP/1KKPFtysdTBaXd81hc2Dz2DnrLrvHplWdbB53ru1h8+jbsorR4/MmuQDWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhldC1TLXjNVbG7Q6eB8QRHFyMnh4SAicTsWSuZIWwxiQv31rN1MXJxCAksZZR43nkPyvnK KNG4exsTSBWbgJXExPZVjCC2iICyxNXve1lAipgFdjBKPNr1nB0kISwQLNGwtpsFxGYRUJVY t+MlK4jNK6Al8WfZCTYQW1TAS2LLvnawoZwCNhKHl1xmhdi2nlHi2Np/LBANghI/Jt8Ds5kF 5CX27Z/KCmFrSazfeZxpAqPALCRls5CUzUJStoCReRWjRGpBckFxUnquUV5quV5xYm5xaV66 XnJ+7iZGcGw9k97BeHiX+yFGAQ5GJR5eC+MtEUKsiWXFlbmHGCU4mJVEeDvCt0YI8aYkVlal FuXHF5XmpBYfYjQF+nAis5Rocj4w7vNK4g1NzE3MjQ0szC0tTYyUxHkbZz8LFxJITyxJzU5N LUgtgulj4uCUamB0MNKdtT5f5a/Dyl1zank7Xva2Tfhx2l0vTHfB0dqEcsnjJjFrL3H4+U49 UsW88EHzde2G9tptMzcLLuhZ9dwp+LHxXDd277bofc95qk13VXZyHhDQmLpWZ0rXmi3iHnnK LFFxP5z/bLp33/ZyePlepkdx9jqXeVpU+BccqW+Qj/zfVqspy6rEUpyRaKjFXFScCAB0nsB+ wwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170228113439epcas5p2307cf9a652807ea80f26b4784233b1b1 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 X-RootMTR: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 References: <4868995.DGOuKygKvi@amdc3058> <20170228094740.kgsanxtum6xj2wdt@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, February 28, 2017 09:47:40 AM Mark Brown wrote: > On Mon, Feb 27, 2017 at 04:52:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday, February 27, 2017 05:32:37 PM Krzysztof Kozlowski wrote: > > > > The driver supports two chipsets: max14577 and max77836. As you noted, > > > the first one is for Gear 1. The second one is present on Gear2 which > > > is supported by mainline. Simplifying the driver to support only > > > max77836 would be a task requiring testing. I think review would be in > > > such case not enough. > > > I think that this shouldn't be a big problem (if no one > > else volunteers we can do the testing on Gear2 device). > > OTOH is it really gaining us much to remove the functionality vs the > effort for testing? Removing the entire driver is fairly > straightforward but if it's just some extra device support that's > sitting there not bothering anyone perhaps it's not really a good use of > time. We have to test the device from time to time anyway just to check that upstream support is still working so it shouldn't be much extra effort. Leaving the code as it is for now is also okay for me (till it starts bothering somebody, i.e. people doing automatic DT bindings coverage/validity checking). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics