From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vweaver1@eecs.utk.edu>
Cc: linux-kernel@vger.kernel.org, fbuihuu@gmail.com, mingo@elte.hu,
paulus@samba.org, acme@redhat.com
Subject: Re: perf: regression with PERF_EVENT_IOC_REFRESH
Date: Tue, 24 May 2011 17:18:38 +0200 [thread overview]
Message-ID: <1306250318.18455.44.camel@twins> (raw)
In-Reply-To: <1306249914.18455.43.camel@twins>
On Tue, 2011-05-24 at 17:11 +0200, Peter Zijlstra wrote:
> On Tue, 2011-05-24 at 11:04 -0400, Vince Weaver wrote:
> > As an aside, I also wasted 6 hours last night finding out that you don't
> > get signaled on overflow if you don't have a ring-buffer mmap()ed, even
> > if you never read from the buffer and you only are interested in counting
> > the number of overflows.
>
> That sounds like something we could fix, let me investigate.
Does the below cure this?
---
kernel/events/core.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index c09767f..bd1ba5e 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5018,9 +5018,12 @@ static int __perf_event_overflow(struct perf_event *event, int nmi,
event->pending_kill = POLL_HUP;
if (nmi) {
event->pending_disable = 1;
+ event->pending_wakeup = 1;
irq_work_queue(&event->pending);
- } else
+ } else {
perf_event_disable(event);
+ perf_event_wakeup(event);
+ }
}
if (event->overflow_handler)
next prev parent reply other threads:[~2011-05-24 15:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 20:04 perf: regression with PERF_EVENT_IOC_REFRESH Vince Weaver
2011-05-23 20:22 ` Peter Zijlstra
2011-05-24 6:20 ` Vince Weaver
2011-05-24 10:30 ` Peter Zijlstra
2011-05-24 15:04 ` Vince Weaver
2011-05-24 15:10 ` Peter Zijlstra
2011-05-24 15:40 ` Ingo Molnar
2011-05-24 20:31 ` Vince Weaver
2011-05-25 10:39 ` Ingo Molnar
2011-05-25 21:24 ` Vince Weaver
2011-05-24 17:53 ` Vince Weaver
2011-05-24 15:11 ` Peter Zijlstra
2011-05-24 15:18 ` Peter Zijlstra [this message]
2011-05-24 21:48 ` Vince Weaver
2011-05-28 3:38 ` Vince Weaver
2011-05-28 10:22 ` Peter Zijlstra
2011-05-28 13:26 ` perf: definition of a "regression" Vince Weaver
2011-06-02 7:45 ` Ingo Molnar
2011-05-29 16:54 ` perf: regression with PERF_EVENT_IOC_REFRESH Vince Weaver
2011-05-31 1:33 ` perf: [patch] " Vince Weaver
2011-05-31 7:17 ` Peter Zijlstra
2011-05-31 7:23 ` Peter Zijlstra
2011-05-31 13:49 ` Vince Weaver
2011-05-31 15:52 ` Peter Zijlstra
2011-05-31 16:39 ` Vince Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306250318.18455.44.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=fbuihuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=vweaver1@eecs.utk.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox