public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Justin TerAvest <teravest@google.com>
Cc: Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] cfq-iosched: reduce bit operations in cfq_choose_req()
Date: Wed, 25 May 2011 11:34:44 +0900	[thread overview]
Message-ID: <1306290884.1319.18.camel@leonhard> (raw)
In-Reply-To: <BANLkTi=kur2RMzUNC4V1R-R86qJZrk1n6Q@mail.gmail.com>

2011-05-24 (화), 10:34 -0700, Justin TerAvest:
> Why make this change? Are we that sensitive to the number of operations?
> 
> It makes the code a bit harder to read, I think.
> 

Hi Justin,

I thought that the function is a sort of hot path operation so it would
be better make it even a bit faster, no? And if you guys think this
patch makes the code harder we can add a comment, although I don't think
it's hard enough. :)

Thanks.


-- 
Regards,
Namhyung Kim



  reply	other threads:[~2011-05-25  2:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24  3:18 [PATCH 1/4] cfq-iosched: algebraic simplification in cfq_prio_to_maxrq() Namhyung Kim
2011-05-24  3:18 ` [PATCH 2/4] cfq-iosched: reduce bit operations in cfq_choose_req() Namhyung Kim
2011-05-24 17:34   ` Justin TerAvest
2011-05-25  2:34     ` Namhyung Kim [this message]
2011-05-24  3:18 ` [PATCH 3/4] cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add() Namhyung Kim
2011-05-24 17:32   ` Justin TerAvest
2011-05-24  3:18 ` [PATCH 4/4] cfq-iosched: free cic_index if cfqd allocation fails Namhyung Kim
2011-05-24  8:13 ` [PATCH 1/4] cfq-iosched: algebraic simplification in cfq_prio_to_maxrq() Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306290884.1319.18.camel@leonhard \
    --to=namhyung@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teravest@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox