public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: y@mail.of.borg
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 1/4] include/linux/printk.h is not self-contained
Date: Wed, 25 May 2011 07:42:31 -0700	[thread overview]
Message-ID: <1306334551.2298.89.camel@Joe-Laptop> (raw)
In-Reply-To: <1306314554-19198-1-git-send-email-y>

On Wed, 2011-05-25 at 11:09 +0200, y@mail.of.borg wrote:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> <linux/printk.h> needs to include
>   - <stdarg.h> for "va_list",
>   - <linux/linkage.h> for "asmlinkage",
>   - <linux/types.h> for "bool".

I wonder if printk should be self-contained.

If so, this patch should also add:

#include <linux/dynamic_debug.h>
#include <linux/ratelimit.h>

If not, maybe add:

#ifndef _LINUX_KERNEL_H
#error don't include <linux/printk.h> directly, use <linux/kernel.h>
#endif

Also asmlinkage is an ancient artifact and should
be removed from the declarations of early_printk,
vprintk, and printk.


  reply	other threads:[~2011-05-25 14:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  9:09 [PATCH 1/4] include/linux/printk.h is not self-contained y
2011-05-25 14:42 ` Joe Perches [this message]
2011-05-25 15:20   ` Geert Uytterhoeven
2011-05-25 15:52     ` Alexey Dobriyan
2011-05-25 17:02     ` [PATCH 0/4] printk: cleanups of direct includes Joe Perches
2011-05-25 17:02       ` [PATCH 1/4] treewide: Remove direct includes of printk.h Joe Perches
2011-05-25 17:02       ` [PATCH 2/4] staging: " Joe Perches
2011-05-26  7:37         ` Roland Vossen
2011-05-29 17:00         ` julie Sullivan
2011-05-29 20:40           ` Joe Perches
2011-05-25 17:02       ` [PATCH 3/4] printk: Don't allow direct inclusion Joe Perches
2011-05-25 17:02       ` [PATCH 4/4] treewide: Remove asmlinkage from printk Joe Perches
2011-05-25 17:09 ` [PATCH 1/4] include/linux/printk.h is not self-contained Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306334551.2298.89.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=y@mail.of.borg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox