From: Peter Zijlstra <peterz@infradead.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-pm <linux-pm@lists.linux-foundation.org>,
mingo@elte.hu, acme@redhat.com, ming.m.lin@intel.com, "Brown,
Len" <lenb@kernel.org>, Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH 2/3] introduce intel_rapl driver
Date: Thu, 26 May 2011 12:21:39 +0200 [thread overview]
Message-ID: <1306405299.1200.51.camel@twins> (raw)
In-Reply-To: <1306403003.1200.41.camel@twins>
On Thu, 2011-05-26 at 11:43 +0200, Peter Zijlstra wrote:
> > + for(id = 0; id < RAPL_DOMAIN_MAX; id++)
> > + if (rapl_domains[id].valid)
> > + perf_pmu_register(&(rapl_domains[id].pmu), rapl_domains[id].pmu.name, PERF_TYPE_SOFTWARE);
>
> Uhm, hell no!, you get to use type = -1.
Also, you don't need a struct pmu per domain.
next prev parent reply other threads:[~2011-05-26 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 8:34 [PATCH 2/3] introduce intel_rapl driver Zhang Rui
2011-05-26 9:43 ` Peter Zijlstra
2011-05-26 10:21 ` Peter Zijlstra [this message]
2011-05-26 10:55 ` Matt Fleming
2011-06-02 8:04 ` Matt Fleming
2011-05-27 8:26 ` Zhang Rui
2011-05-27 19:56 ` Peter Zijlstra
2011-05-27 19:56 ` Peter Zijlstra
2011-05-30 3:11 ` Zhang Rui
2011-05-26 15:48 ` Randy Dunlap
2011-05-30 2:40 ` Zhang Rui
2011-05-28 10:17 ` Greg KH
2011-05-30 7:04 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306405299.1200.51.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=matt@console-pimps.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox