From: Joe Perches <joe@perches.com>
To: Manish Kumar Singh <man.k1983@gmail.com>
Cc: anish <anish198519851985@gmail.com>,
davej@redhat.com, rostedt@goodmis.org, apw@shadowen.org,
akpm@linux-foundation.org, vapier@gentoo.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch v4] checkpatch: Signature format verification
Date: Fri, 27 May 2011 12:08:08 -0700 [thread overview]
Message-ID: <1306523288.31864.29.camel@Joe-Laptop> (raw)
In-Reply-To: <BANLkTikfh_ABGomn-Lm9Ugc7MzeRodwiEQ@mail.gmail.com>
On Sat, 2011-05-28 at 00:28 +0530, Manish Kumar Singh wrote:
> On Fri, May 27, 2011 at 11:59 PM, Joe Perches <joe@perches.com> wrote:
[]
> 8 bit chars, digits?
> What is 8 bit char...could you describe it?
An ascii char with the high order bit set.
Any char from 128 to 255.
[]
> For the 3rd time, please use this form:
> if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) {
> and if you really want email format validation,
> use a separate function.
[]
> Problem with your way of doing is if anyone misses space between
> "sign" & name,
> the regular expression (/^(\s*)($ValidSignatures)(\s*)(.*)$/i )
> doesn't match
That's incorrect. Try it.
next prev parent reply other threads:[~2011-05-27 19:08 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 19:38 PATCH] patch to generate warning when signed-of line in patch in not proper anish
2011-05-21 19:52 ` Joe Perches
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
2011-05-22 14:16 ` Joe Perches
[not found] ` <BANLkTimMPvn87E0EEqT4vhox4_8nQ4pMug@mail.gmail.com>
2011-05-23 4:14 ` Joe Perches
2011-05-23 16:22 ` Steven Rostedt
2011-05-23 16:30 ` Joe Perches
2011-05-23 15:21 ` [patch v3] " anish
2011-05-23 16:11 ` Joe Perches
[not found] ` <BANLkTi=9nzMbxU0=P+pOaHcebqhL=bd2HQ@mail.gmail.com>
2011-05-23 16:36 ` Joe Perches
2011-05-23 16:39 ` Randy Dunlap
2011-05-23 16:42 ` Joe Perches
[not found] ` <BANLkTik8coVxt=Z92NQBNH_=4yRhTtexzA@mail.gmail.com>
2011-05-23 17:07 ` Randy Dunlap
2011-05-23 17:18 ` Joe Perches
[not found] ` <BANLkTikqezyJMy1_i-woTVM9bvVL750iew@mail.gmail.com>
2011-05-23 18:09 ` Joe Perches
2011-05-23 22:51 ` Mike Frysinger
2011-05-24 1:24 ` Valdis.Kletnieks
2011-05-24 1:31 ` Mike Frysinger
2011-05-24 4:44 ` Randy Dunlap
2011-05-27 18:01 ` [patch v4] " anish
2011-05-27 18:16 ` Steven Rostedt
2011-05-27 18:18 ` Randy Dunlap
2011-05-27 18:45 ` Joe Perches
2011-05-27 18:58 ` Joe Perches
2011-05-27 19:22 ` Steven Rostedt
2011-05-27 19:33 ` Joe Perches
2011-05-27 18:29 ` Joe Perches
[not found] ` <BANLkTikfh_ABGomn-Lm9Ugc7MzeRodwiEQ@mail.gmail.com>
2011-05-27 19:08 ` Joe Perches [this message]
[not found] ` <BANLkTi=JK+XS2D0exj=unjpjGCsnVncCzQ@mail.gmail.com>
2011-05-27 19:33 ` Joe Perches
[not found] ` <BANLkTi=dsYi3ViZdpGdagxzhzDRuRVL_+A@mail.gmail.com>
2011-05-27 20:18 ` Steven Rostedt
2011-05-27 20:37 ` Joe Perches
[not found] ` <BANLkTi=VuLpdAf3Qo3mo_nQ03yHazeHf+g@mail.gmail.com>
2011-05-28 1:42 ` Joe Perches
2011-05-27 22:14 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306523288.31864.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anish198519851985@gmail.com \
--cc=apw@shadowen.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=man.k1983@gmail.com \
--cc=rostedt@goodmis.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox