From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW_LEDS
Date: Sat, 28 May 2011 17:52:56 +0800 [thread overview]
Message-ID: <1306576376.10669.12.camel@phoenix> (raw)
Commit 4440673a "leds: provide helper to register "leds-gpio" devices"
adds "config LEDS_GPIO_REGISTER" in drivers/leds/Kconfig.
However, config LEDS_GPIO_REGISTER does not depend on NEW_LEDS, while executing
make menuconfig a side-effect is observed that the "LED drivers" and
"LED Triggers" are now displayed at the same level of "LED Support".
( They was in sub-menu of "LED Support" before the commit. )
This patch makes LEDS_GPIO_REGISTER depend on NEW_LEDS to correctly show
"LED drivers" and "LED Triggers" in sub-menu of "LED Support".
Besides, LEDS_GPIO_REGISTER is set to be bool but no description. Thus I
cannot find LEDS_GPIO_REGISTER config option while executing make menuconfig.
This patch also adds the description for LEDS_GPIO_REGISTER so the option can
be correctly displayed.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/leds/Kconfig | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..784f74f 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -15,7 +15,8 @@ config LEDS_CLASS
need this to do anything useful with LEDs. If unsure, say N.
config LEDS_GPIO_REGISTER
- bool
+ bool "LED GPIO Register Support"
+ depends on NEW_LEDS
help
This option provides the function gpio_led_register_device.
As this function is used by arch code it must not be compiled as a
--
1.7.1
next reply other threads:[~2011-05-28 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 9:52 Axel Lin [this message]
2011-05-28 17:47 ` [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW_LEDS Uwe Kleine-König
2011-05-29 1:38 ` Axel Lin
2011-05-31 6:52 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306576376.10669.12.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox