From: Connor Hansen <cmdkhh@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Borislav Petkov <bp@alien8.de>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Connor Hansen <cmdkhh@gmail.com>
Subject: [PATCH 1/2] ide-cd: Fix signedness warning
Date: Mon, 30 May 2011 00:13:32 -0700 [thread overview]
Message-ID: <1306739612-29239-1-git-send-email-cmdkhh@gmail.com> (raw)
One of the legit warnings 'make W=3 drivers/ide/ide-cd.o´ generates is
drivers/ide/ide-cd.c: In function .ide_cdrom_prep_fs.:
drivers/ide/ide-cd.c:1314: warning: conversion to .unsigned int. from .int. may change the sign of the result
because queue_logical_block_size() returns unsigned short but hard_sect
is defined as int. Fix that no matter how low the potential for this
becoming a bug is.
Signed-off-by: Connor Hansen <cmdkhh@gmail.com>
---
drivers/ide/ide-cd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 6e5123b..c1de54a 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -1309,7 +1309,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive)
/* standard prep_rq_fn that builds 10 byte cmds */
static int ide_cdrom_prep_fs(struct request_queue *q, struct request *rq)
{
- int hard_sect = queue_logical_block_size(q);
+ unsigned short hard_sect = queue_logical_block_size(q);
long block = (long)blk_rq_pos(rq) / (hard_sect >> 9);
unsigned long blocks = blk_rq_sectors(rq) / (hard_sect >> 9);
--
1.7.4.4
next reply other threads:[~2011-05-30 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 7:13 Connor Hansen [this message]
2011-05-31 22:23 ` [PATCH 1/2] ide-cd: Fix signedness warning David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306739612-29239-1-git-send-email-cmdkhh@gmail.com \
--to=cmdkhh@gmail.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox