public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf script: fix display of IP address for non-callchain path
@ 2011-05-30 15:16 David Ahern
  2011-07-17 17:31 ` Frederic Weisbecker
  2011-07-21 10:11 ` [tip:perf/core] perf script: Fix " tip-bot for David Ahern
  0 siblings, 2 replies; 3+ messages in thread
From: David Ahern @ 2011-05-30 15:16 UTC (permalink / raw)
  To: linux-perf-users, linux-kernel
  Cc: acme, mingo, peterz, fweisbec, paulus, tglx, David Ahern

Non-callchain path is using al.addr which prints as:
  openssl 14564 17672.003587:       7862d _x86_64_AES_encrypt_compact

This should be sample->ip to print as:
  openssl 14564 17672.003587:  3f7867862d _x86_64_AES_encrypt_compact

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 tools/perf/util/session.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index e6cf0e2..360d8c4 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1247,7 +1247,7 @@ void perf_session__print_ip(union perf_event *event,
 		}
 
 	} else {
-		printf("%16" PRIx64, al.addr);
+		printf("%16" PRIx64, sample->ip);
 		if (print_sym) {
 			if (al.sym && al.sym->name)
 				symname = al.sym->name;
-- 
1.7.5.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf script: fix display of IP address for non-callchain path
  2011-05-30 15:16 [PATCH] perf script: fix display of IP address for non-callchain path David Ahern
@ 2011-07-17 17:31 ` Frederic Weisbecker
  2011-07-21 10:11 ` [tip:perf/core] perf script: Fix " tip-bot for David Ahern
  1 sibling, 0 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2011-07-17 17:31 UTC (permalink / raw)
  To: David Ahern, Peter Zijlstra, Arnaldo Carvalho de Melo,
	Ingo Molnar
  Cc: linux-perf-users, linux-kernel, paulus, tglx

On Mon, May 30, 2011 at 09:16:27AM -0600, David Ahern wrote:
> Non-callchain path is using al.addr which prints as:
>   openssl 14564 17672.003587:       7862d _x86_64_AES_encrypt_compact
> 
> This should be sample->ip to print as:
>   openssl 14564 17672.003587:  3f7867862d _x86_64_AES_encrypt_compact
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

> ---
>  tools/perf/util/session.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index e6cf0e2..360d8c4 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1247,7 +1247,7 @@ void perf_session__print_ip(union perf_event *event,
>  		}
>  
>  	} else {
> -		printf("%16" PRIx64, al.addr);
> +		printf("%16" PRIx64, sample->ip);
>  		if (print_sym) {
>  			if (al.sym && al.sym->name)
>  				symname = al.sym->name;
> -- 
> 1.7.5.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/core] perf script: Fix display of IP address for non-callchain path
  2011-05-30 15:16 [PATCH] perf script: fix display of IP address for non-callchain path David Ahern
  2011-07-17 17:31 ` Frederic Weisbecker
@ 2011-07-21 10:11 ` tip-bot for David Ahern
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for David Ahern @ 2011-07-21 10:11 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, fweisbec, dsahern, tglx, mingo

Commit-ID:  adc4bf9955856f8aa081ba613dbf56ffd664f0b7
Gitweb:     http://git.kernel.org/tip/adc4bf9955856f8aa081ba613dbf56ffd664f0b7
Author:     David Ahern <dsahern@gmail.com>
AuthorDate: Mon, 30 May 2011 09:16:27 -0600
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 21 Jul 2011 10:09:28 +0200

perf script: Fix display of IP address for non-callchain path

Non-callchain path is using al.addr which prints as:
  openssl 14564 17672.003587:       7862d _x86_64_AES_encrypt_compact

This should be sample->ip to print as:
  openssl 14564 17672.003587:  3f7867862d _x86_64_AES_encrypt_compact

Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: acme@ghostprotocols.net
Cc: peterz@infradead.org
Cc: paulus@samba.org
Link: http://lkml.kernel.org/r/1306768587-15376-1-git-send-email-dsahern@gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/util/session.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index a3c13bc..72458d9 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1269,7 +1269,7 @@ void perf_session__print_ip(union perf_event *event,
 		}
 
 	} else {
-		printf("%16" PRIx64, al.addr);
+		printf("%16" PRIx64, sample->ip);
 		if (print_sym) {
 			if (al.sym && al.sym->name)
 				symname = al.sym->name;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-21 10:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-30 15:16 [PATCH] perf script: fix display of IP address for non-callchain path David Ahern
2011-07-17 17:31 ` Frederic Weisbecker
2011-07-21 10:11 ` [tip:perf/core] perf script: Fix " tip-bot for David Ahern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox