From: Mike Galbraith <efault@gmx.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Yong Zhang <yong.zhang0@gmail.com>
Subject: Re: [PATCH] sched: fix need_resched() when checking peempt
Date: Tue, 31 May 2011 05:26:24 +0200 [thread overview]
Message-ID: <1306812384.7903.3.camel@marge.simson.net> (raw)
In-Reply-To: <BANLkTin2r7omjQC9ro0f2_qEc8SzPX33Pg@mail.gmail.com>
On Tue, 2011-05-24 at 21:50 +0800, Hillf Danton wrote:
> On Tue, May 24, 2011 at 9:39 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Tue, 2011-05-24 at 21:27 +0800, Hillf Danton wrote:
> >> When checking if current task could be preempted by a newly woken task,
> >> further check could be bypassed if the current thread is different from
> >> the current task of run-queue, and it is corrected accordingly.
> >
> > Ug, that change log is an obfuscated mess. But looking at the actual
> > patch, I figured what you wanted to say. How about this:
> >
> > ----
> > The RT preempt check tests the wrong task if NEED_RESCHED is set. It
> > currently checks the local CPU task. It is suppose to check the task
> > that is running on the run queue we are about to wake another task on.
> > ----
> >
> Thanks, it is great changelog:)
Has this been queued, or is it awaiting re-submission?
-Mike
next prev parent reply other threads:[~2011-05-31 3:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 13:27 [PATCH] sched: fix need_resched() when checking peempt Hillf Danton
2011-05-24 13:39 ` Steven Rostedt
2011-05-24 13:50 ` Hillf Danton
2011-05-25 3:24 ` Yong Zhang
2011-05-25 4:34 ` Yong Zhang
2011-05-25 4:44 ` Mike Galbraith
2011-05-31 3:26 ` Mike Galbraith [this message]
2011-05-31 13:18 ` [PATCH resend] " Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306812384.7903.3.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox