Re: [PATCH v14 4/9] usb: Add max_speed to usb_composite_driver structure

Alan Stern
2011-06-06T15:25:19Z

On Mon, 6 Jun 2011, Felipe Balbi wrote:

> But we might still want to force HighSpeed even though the HW has
> SuperSpeed support.

That would be a useful module parameter for a SuperSpeed UDC driver.
Like the parameter Tanya added to dummy-hcd.

> The real solution, for the long run would be to
> always start with pullups disabled (iow, don't connect to host
> immediately) and only connect after the gadget driver is all
> initialized, then we will know the gadget speed before connecting, and
> we can have the gadget driver "request" for a particular speed from the
> controller.

Unfortunately this would mean changing a bunch of UDC drivers. But I
agree, it makes sense for the gadget driver to specifically ask for the
pullups to be enabled when it is ready.

Don't some of the existing UDC drivers fail to implement the pullup
method at all?

Alan Stern