Re: [GIT PULL] x86 fixes

Andrew Morton
2018-01-18T00:29:47Z

On Thu, 18 Jan 2018 01:24:08 +0100 Ingo Molnar <mingo@kernel.org> wrote:

>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Wed, Jan 17, 2018 at 7:41 AM, Ingo Molnar <mingo@kernel.org> wrote:
> > >
> > > - A kdump fix
> > >
> > > out-of-topic modifications in x86-urgent-for-linus:
> > > -----------------------------------------------------
> > > include/linux/crash_core.h # 9f15b9120f56: kdump: Write the correct add
> > > kernel/crash_core.c # 9f15b9120f56: kdump: Write the correct add
> >
> > This came through Andrew too. It all merged fine since there were no
> > other modifications, but it's a bit odd how this was in the x86 tree,
> > and even if that part makes sense it's a sign of lack of communication
> > at some point.
> >
> > Oh well. Not a big deal. I just thought I'd mention it.
>
> Hm, I don't think Andrew Cc:-ed me when he sent it to you, so I didn't notice the
> duplication. The bug was introduced via the 5-level paging changes in the x86
> tree, so I assumed the fix would go via the x86 tree as well.
>
> Andrew was Cc:-ed to the -tip commit.

I cc'ed the whole world on that one:

Acked-by: Baoquan He <bhe@redhat.com>
Acked-by: Dave Young <dyoung@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: <stable@vger.kernel.org>

but yeah, I make a lot of noise ;)

Ordinarily I'll auto-drop such things if they turn up in linux-next but
it seems this one got fast-tracked in -tip so that mechanism didn't
work (this is rare).