Re: [GIT PULL] x86 fixes

H. Peter Anvin
2010-01-16T21:10:20Z

On 01/16/2010 01:06 PM, H. Peter Anvin wrote:
> On 01/16/2010 12:34 PM, Linus Torvalds wrote:
>>
>>
>> On Sat, 16 Jan 2010, Ingo Molnar wrote:
>>>
>>> Cyrill Gorcunov (1):
>>> x86: kernel_thread() -- initialize SS to a known state
>>
>> This looks bogus. Why does it do it only on x86-64?
>>
>> Either people care about SS or they don't (the answer, I suspect, is "they
>> don't"). But if they care, we should do it on both 32-bit _and_ 64-bit,
>> no?
>>
>
> It is bogus -- it's basically Xen braindamage.
>

As to why make it x86-64 only... it matches what the old assembly code
did. We figured that that was the lowest risk option for unbreaking Xen.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.