Re: [GIT PULL] x86 fixes

Linus Torvalds
2015-08-14T18:57:49Z

On Fri, Aug 14, 2015 at 11:46 AM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> I think it's only slightly broken.
>
> This bit:
>
> if ((FPU_CS & 4) != 4) { /* Must be in the LDT */
> /* Can only handle segmented addressing via the LDT
> for now, and it must be 16 bit */
> printk("FPU emulator: Unsupported addressing mode\n");
> math_abort(FPU_info, SIGILL);
> }
>
> code_descriptor = FPU_get_ldt_descriptor(FPU_CS);
>
> is buggy, but no buggier than the old code.

That code seems fine to me (and explicitly errors out when it's not in
the LDT). FPU_CS is actually the CS selector value.

So testing that for being in the LDT by checking bit #2, and then
using FPU_get_ldt_descriptor() on it actually seems *correct*.

It's the actual instruction data segment handling that looks entirely
broken, and was explicitly made *more* broken by that commit.

The FPU emulation code has two different kinds of segment defines:

- the PREFIX_xx_ defines are the segment register numbers (well,
prefix numbers)

- the FPU_CS/SS/DS defines are the current selector values for those.

and yes, it's confusing how it tends to use the variable name
"segment" for the prefix number, when in the rest of the kernel we
tend to always track the selector value.

Linus