Re: [GIT PULL] x86 fixes

Ingo Molnar
2011-05-31T19:05:03Z

* Borislav Petkov <bp@amd64.org> wrote:

> On Tue, May 31, 2011 at 09:35:09AM -0700, Joe Perches wrote:
> > On Tue, 2011-05-31 at 18:30 +0200, Ingo Molnar wrote:
> > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> > []
> > > @@ -642,7 +642,7 @@ static int __init idle_setup(char *str)
> > > boot_option_idle_override = IDLE_POLL;
> > > } else if (!strcmp(str, "mwait")) {
> > > boot_option_idle_override = IDLE_FORCE_MWAIT;
> > > - WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> > > + WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\"\n");
> >
> > Extra quote at end. More likely you want:
> >
> > WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012\n");
>
> Crap, there's no fixing this string :)
>
> Reportedly, there's another fix from Len:
>
> lkml.kernel.org/r/20110531101934.2737dc90.sfr@canb.auug.org.au
>
> which is more complete. Ingo, you could drop this one.

Well, the primary problem, which needed x86/urgent treatment, was the
annoying build warning affecting all users.

The message itself is exceedingly rare, so we can fix it via lower
prio pathways.

Len, a small detail: mind resolving the conflict once it occurs by
dropping the \" but keeping the \n? Your commit:

8a27ef90237f: x86 idle: fix build warning for WARN_ONCE("idle=mwait")

removes the \n from the end of a printk-alike string - we generally
keep the \n even though WARN_*() will accept \n-less strings.

Thanks,

Ingo