Re: [git pull] x86 fixes

Adrian Bunk
2008-05-05T15:13:18Z

On Sun, May 04, 2008 at 09:35:42PM +0200, Ingo Molnar wrote:
>...
> Thomas Gleixner (2):
>...
> x86: olpc build fix
>...
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1661,6 +1661,7 @@ config GEODE_MFGPT_TIMER
>
> config OLPC
> bool "One Laptop Per Child support"
> + depends on MGEODE_LX
> default n
> help
>...

This patch not only excludes OLPC and code depending on it (currently
BATTERY_OLPC) from all{mod,yes}config builds (where it built fine)
but also makes it very hard for generic distribution kernels to
support the OLPC.

The commit comment does not indicate what the actual problem was, and if
this patch was sent to linux-kernel I must have missed it.

What exactly was the build problem?
Can we fix it in a less invasive way?

Thanks in advance
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed