Re: [GIT PULL] x86 fixes

Brian Gerst
2010-01-17T00:18:18Z

On Sat, Jan 16, 2010 at 3:34 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
>
> On Sat, 16 Jan 2010, Ingo Molnar wrote:
>>
>> Cyrill Gorcunov (1):
>>       x86: kernel_thread() -- initialize SS to a known state
>
> This looks bogus. Why does it do it only on x86-64?
>
> Either people care about SS or they don't (the answer, I suspect, is "they
> don't"). But if they care, we should do it on both 32-bit _and_ 64-bit,
> no?

32-bit doesn't care about ss or esp since it won't pop them from the
stack when returning to the same privilege level.

--
Brian Gerst