Re: [git pull] x86 fixes

Adrian Bunk
2008-09-09T17:45:28Z

On Tue, Sep 09, 2008 at 10:03:53AM -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
>>
>> As far as I understood it it's a gas issue, and X86_GENERIC=y would
>> therefore *not* fix the bug with gcc < 4.2 and affected binutils
>> since we pass -mtune=i686 for gcc < 4.2 with X86_GENERIC=y.
>>
>> Anything I miss?
>
> Well, for one thing, gcc doesn't actually pass the -mtune= option to
> gas, it turns out.

What caused gas to emit the "wrong" NOPs?

> But yes, "-Wa,-march=generic32" is really the proper fix.

If I understand the binutils changelog correctly -march=generic32
support was added one week before the NOP code in question, so all
affected binutils versions support it.

> -hpa

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed