Re: [GIT PULL] x86 fixes

Ian Campbell
2010-01-17T06:00:32Z

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Sat, 2010-01-16 at 19:18 -0500, Brian Gerst wrote:
> On Sat, Jan 16, 2010 at 3:34 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> >
> > On Sat, 16 Jan 2010, Ingo Molnar wrote:
> >>
> >> Cyrill Gorcunov (1):
> >> x86: kernel_thread() -- initialize SS to a known state
> >
> > This looks bogus. Why does it do it only on x86-64?
> >
> > Either people care about SS or they don't (the answer, I suspect, is "they
> > don't"). But if they care, we should do it on both 32-bit _and_ 64-bit,
> > no?
>
> 32-bit doesn't care about ss or esp since it won't pop them from the
> stack when returning to the same privilege level.

Right! That's the bit of behaviour I wasn't thinking of.

Thanks, Ian.

--
Ian Campbell

Under every stone lurks a politician.
-- Aristophanes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]