Re: [GIT PULL] x86 fixes

Ingo Molnar
2014-09-24T07:26:39Z

* Matt Fleming <matt@console-pimps.org> wrote:

> @@ -1394,10 +1394,7 @@ struct boot_params *efi_main(struct efi_config *c,
>
> setup_graphics(boot_params);
>
> - status = setup_efi_pci(boot_params);
> - if (status != EFI_SUCCESS) {
> - efi_printk(sys_table, "setup_efi_pci() failed!\n");
> - }
> + setup_efi_pci(boot_params);
>
> status = efi_call_early(allocate_pool, EFI_LOADER_DATA,
> sizeof(*gdt), (void **)&gdt);

So 'status' is unused - either use it for a less threatening
message, or remove the return code from the function and document
that failure is an option?

Thanks,

Ingo