Re: [GIT PULL] x86 fixes

Matt Fleming
2014-09-24T13:18:26Z

On Wed, 24 Sep, at 03:08:16PM, Ingo Molnar wrote:
>
> * Matt Fleming <matt@console-pimps.org> wrote:
>
> > +/*
> > + * There's no way to return an informative status from this function,
> > + * because any analysis (and printing of error messages) needs to be
> > + * done directly at the EFI function call-site.
> > + *
> > + * For example, EFI_INVALID_PARAMETER could indicate a bug or maybe we
> > + * just didn't find any PCI devices, but there's no way to tell outside
> > + * the context of the call.
> > + */
> > +static void setup_efi_pci(struct boot_params *params)
>
> Btw., do we print proper complaints at the EFI call sites if such
> failures do happen (and if that failure is unexpected/bad)?

Not yet, but I've got a patch queued up for v3.18 that does this.

--
Matt Fleming, Intel Open Source Technology Center