From: John Stultz <john.stultz@linaro.org>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, richard.cochran@omicron.at,
tglx@linutronix.de, arnd@arndb.de, peterz@infradead.org,
toralf.foerster@gmx.de
Subject: Re: [RFC][PATCH] timers: Make alarmtimer depend on CONFIG_RTC_CLASS
Date: Tue, 31 May 2011 23:38:16 -0700 [thread overview]
Message-ID: <1306910297.3359.49.camel@work-vm> (raw)
In-Reply-To: <1306666131-6161-1-git-send-email-richard@nod.at>
On Sun, 2011-05-29 at 12:48 +0200, Richard Weinberger wrote:
> The alarmtimer interface makes IMHO only sense when a RTC device
> is available.
> On systems with !CONFIG_RTC_CLASS (like UML) the warning
> "Kernel not built with RTC support, ALARM timers will not wake from suspend"
> is annoying.
Yea.
The tradeoff with this patch is that applications that use
CLOCK_REALTIME_ALARM or CLOCK_BOOTTIME_ALARM will then get -EINVAL.
I'm mixed here, since we probably want to communicate to the application
that the alarm timers aren't going to wake us up, but also I suspect
most applications won't handle the -EINVAL properly, so I had allowed
for the clockids to still work as long as we didn't suspend.
I'm leaning more towards just returning EINVAL as you suggest, since
really the functionality isn't there. But I'm thinking possibly doing so
if no RTCs are detected at runtime (rather then using all the ifdefs you
do).
Thoughts from anyone else?
thanks
-john
next prev parent reply other threads:[~2011-06-01 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 10:48 [RFC][PATCH] timers: Make alarmtimer depend on CONFIG_RTC_CLASS Richard Weinberger
2011-06-01 6:38 ` John Stultz [this message]
2011-06-01 9:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306910297.3359.49.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=richard.cochran@omicron.at \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox