From: john stultz <johnstul@us.ibm.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 6/6] clocksource: tile: convert to use clocksource_register_hz
Date: Wed, 01 Jun 2011 10:55:30 -0700 [thread overview]
Message-ID: <1306950930.3359.61.camel@work-vm> (raw)
In-Reply-To: <4DE66645.6020406@tilera.com>
On Wed, 2011-06-01 at 12:18 -0400, Chris Metcalf wrote:
> On 6/1/2011 3:32 AM, John Stultz wrote:
> > From: John Stultz <johnstul@us.ibm.com>
> >
> > Convert tile to use clocksource_register_hz.
> >
> > Untested. Help from maintainers would be appreciated.
> >
> > CC: Chris Metcalf <cmetcalf@tilera.com>
>
> This patch boots up fine on tile. It provides a shift count of 31, with a
> mult value in the billions. This does mean that clocksource_cyc2ns() will
> only be able to give correct timer conversions for up to about 9 seconds.
> Is this believed to be adequate for all the uses the cycle counter is put
> to? I can run our normal regression tests, but I'd like to get a
> high-level sanity check from the clocksource folks.
I believe 9 seconds should be plenty for timekeeping, so I suspect it
should be fine. Although I've not closely checked in this case if the
tile clocksource is used for other purposes, so do let me know if you
see any issues in your testing.
Additionally Thomas has a patch (which I thought already landed in
3.0-rc, but maybe not) which should pick a shift value that gets us
close to 600 second intervals (hardware allowing), allowing for much
longer NOHZ periods.
The important part is that we're centralizing this logic so it can be
properly adjusted without having to tune 30-some clocksources
individually.
Thanks for the testing and review!
-john
next prev parent reply other threads:[~2011-06-01 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 7:32 [PATCH 0/6] clocksource_register_hz/khz cleanups John Stultz
2011-06-01 7:32 ` [PATCH 1/6] clocksource: Convert tcb_clksrc to use clocksource_register_hz/khz John Stultz
2011-06-01 7:32 ` [PATCH 2/6] clocksource: parisc: convert to clocksource_register_hz/khz John Stultz
2011-06-01 7:32 ` [PATCH 3/6] clocksource: um: " John Stultz
2011-06-01 7:32 ` [PATCH 4/6] clocksource: xtensa: " John Stultz
2011-06-01 7:32 ` [PATCH 5/6] clocksource: cris: convert to clocksource_register_khz John Stultz
2011-06-01 7:32 ` [PATCH 6/6] clocksource: tile: convert to use clocksource_register_hz John Stultz
2011-06-01 16:18 ` Chris Metcalf
2011-06-01 17:55 ` john stultz [this message]
2011-06-03 21:27 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306950930.3359.61.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox