public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw_random: timeriomem-rng: use resource_size
@ 2011-06-01 22:23 H Hartley Sweeten
  2011-06-02 19:25 ` Matt Mackall
  0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2011-06-01 22:23 UTC (permalink / raw)
  To: Linux Kernel; +Cc: mpm, herbert

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Matt Mackall <mpm@selenic.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>

---

diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
index a94e930..a8428e6 100644
--- a/drivers/char/hw_random/timeriomem-rng.c
+++ b/drivers/char/hw_random/timeriomem-rng.c
@@ -100,8 +100,7 @@ static int __devinit timeriomem_rng_probe(struct platform_device *pdev)
 
 	timeriomem_rng_data = pdev->dev.platform_data;
 
-	timeriomem_rng_data->address = ioremap(res->start,
-						res->end - res->start + 1);
+	timeriomem_rng_data->address = ioremap(res->start, resource_size(res));
 	if (!timeriomem_rng_data->address)
 		return -EIO;
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw_random: timeriomem-rng: use resource_size
  2011-06-01 22:23 [PATCH] hw_random: timeriomem-rng: use resource_size H Hartley Sweeten
@ 2011-06-02 19:25 ` Matt Mackall
  2011-06-08 13:06   ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Matt Mackall @ 2011-06-02 19:25 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Linux Kernel, herbert

On Wed, 2011-06-01 at 15:23 -0700, H Hartley Sweeten wrote:
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Matt Mackall <mpm@selenic.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>

Looks good to me.

Acked-by: Matt Mackall <mpm@selenic.com>

> ---
> 
> diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
> index a94e930..a8428e6 100644
> --- a/drivers/char/hw_random/timeriomem-rng.c
> +++ b/drivers/char/hw_random/timeriomem-rng.c
> @@ -100,8 +100,7 @@ static int __devinit timeriomem_rng_probe(struct platform_device *pdev)
>  
>  	timeriomem_rng_data = pdev->dev.platform_data;
>  
> -	timeriomem_rng_data->address = ioremap(res->start,
> -						res->end - res->start + 1);
> +	timeriomem_rng_data->address = ioremap(res->start, resource_size(res));
>  	if (!timeriomem_rng_data->address)
>  		return -EIO;
>  


-- 
Mathematics is the supreme nostalgia of our time.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw_random: timeriomem-rng: use resource_size
  2011-06-02 19:25 ` Matt Mackall
@ 2011-06-08 13:06   ` Herbert Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2011-06-08 13:06 UTC (permalink / raw)
  To: Matt Mackall; +Cc: H Hartley Sweeten, Linux Kernel

On Thu, Jun 02, 2011 at 02:25:11PM -0500, Matt Mackall wrote:
> On Wed, 2011-06-01 at 15:23 -0700, H Hartley Sweeten wrote:
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Matt Mackall <mpm@selenic.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> 
> Looks good to me.
> 
> Acked-by: Matt Mackall <mpm@selenic.com>

Also applied.  Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-08 13:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 22:23 [PATCH] hw_random: timeriomem-rng: use resource_size H Hartley Sweeten
2011-06-02 19:25 ` Matt Mackall
2011-06-08 13:06   ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox