From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
David Ahern <daahern@cisco.com>, Ingo Molnar <mingo@elte.hu>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Tom Zanussi <tzanussi@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 4/9] perf python: Fix argument name list of read_on_cpu()
Date: Thu, 2 Jun 2011 17:56:31 -0300 [thread overview]
Message-ID: <1307048196-16387-5-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1307048196-16387-1-git-send-email-acme@infradead.org>
From: Frederic Weisbecker <fweisbec@gmail.com>
Mandatory arguments need to be present in the argument name list, as
well as optional arguments, otherwise python barfs:
# ./python/twatch.py
Traceback (most recent call last):
File "./python/twatch.py", line 41, in <module>
main()
File "./python/twatch.py", line 32, in main
event = evlist.read_on_cpu(cpu)
RuntimeError: more argument specifiers than keyword list entries
Hence, add cpu to the name list.
Cc: David Ahern <daahern@cisco.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
Link: http://lkml.kernel.org/r/1301588863-20210-1-git-send-email-fweisbec@gmail.com
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/python.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
index 24063b4..a9ac050 100644
--- a/tools/perf/util/python.c
+++ b/tools/perf/util/python.c
@@ -674,7 +674,7 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist,
struct perf_evlist *evlist = &pevlist->evlist;
union perf_event *event;
int sample_id_all = 1, cpu;
- static char *kwlist[] = {"sample_id_all", NULL, NULL};
+ static char *kwlist[] = {"cpu", "sample_id_all", NULL, NULL};
int err;
if (!PyArg_ParseTupleAndKeywords(args, kwargs, "i|i", kwlist,
--
1.6.2.5
next prev parent reply other threads:[~2011-06-02 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 20:56 [GIT PULL 0/9] perf/core fixes and improvements Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 1/9] perf evlist: Remove dependency on debug routines Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 2/9] perf python: Use exception to propagate errors Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 3/9] perf evlist: Don't die if sample_{id_all|type} is invalid Arnaldo Carvalho de Melo
2011-06-02 20:56 ` Arnaldo Carvalho de Melo [this message]
2011-06-02 20:56 ` [PATCH 5/9] perf python: Cleanup useless double NULL termination in method arg names Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 6/9] perf stat: clarify unsupported events from uncounted events Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 7/9] perf script: "sym" field really means show IP data Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 8/9] perf script: Make printing of dso a separate field option Arnaldo Carvalho de Melo
2011-06-02 20:56 ` [PATCH 9/9] perf script: Add printing of sample address Arnaldo Carvalho de Melo
2011-06-03 15:05 ` [GIT PULL 0/9] perf/core fixes and improvements Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307048196-16387-5-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=daahern@cisco.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).