public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build warning from Linus' tree
@ 2011-06-03  1:00 Stephen Rothwell
  2011-06-03 14:50 ` [PATCH] btrfs: fix uninitialized variable warning David Sterba
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2011-06-03  1:00 UTC (permalink / raw)
  To: Chris Mason
  Cc: linux-next, linux-kernel, Miao Xie, David Sterba, Tsutomu Itoh,
	Itaru Kitayama

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

With Linus' tree, today's linux-next build (powercp ppc64_defconfig)
produced this warning:

fs/btrfs/delayed-inode.c: In function 'btrfs_delayed_update_inode':
fs/btrfs/delayed-inode.c:1598:6: warning: 'ret' may be used uninitialized in this function

Introduced by commit 16cdcec736cd ("btrfs: implement delayed inode items
operation").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH] btrfs: fix uninitialized variable warning
@ 2023-03-24  2:08 Genjian
  2023-03-24  2:24 ` Qu Wenruo
  2023-04-06 19:12 ` David Sterba
  0 siblings, 2 replies; 11+ messages in thread
From: Genjian @ 2023-03-24  2:08 UTC (permalink / raw)
  To: clm, josef, dsterba; +Cc: linux-btrfs, linux-kernel, Genjian Zhang, k2ci

From: Genjian Zhang <zhanggenjian@kylinos.cn>

compiler warning:

../fs/btrfs/volumes.c: In function ‘btrfs_init_new_device’:
../fs/btrfs/volumes.c:2703:3: error: ‘seed_devices’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
 2703 |   btrfs_setup_sprout(fs_info, seed_devices);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../fs/btrfs/send.c: In function ‘get_cur_inode_state’:
../include/linux/compiler.h:70:32: error: ‘right_gen’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   70 |   (__if_trace.miss_hit[1]++,1) :  \
      |                                ^
../fs/btrfs/send.c:1878:6: note: ‘right_gen’ was declared here
 1878 |  u64 right_gen;
      |      ^~~~~~~~~

Initialize the uninitialized variables.

Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
---
 fs/btrfs/send.c    | 2 +-
 fs/btrfs/volumes.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index e5c963bb873d..af2e153543a5 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -1875,7 +1875,7 @@ static int get_cur_inode_state(struct send_ctx *sctx, u64 ino, u64 gen,
 	int left_ret;
 	int right_ret;
 	u64 left_gen;
-	u64 right_gen;
+	u64 right_gen = 0;
 	struct btrfs_inode_info info;
 
 	ret = get_inode_info(sctx->send_root, ino, &info);
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 7823168c08a6..7163c98e47be 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2609,7 +2609,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
 	struct block_device *bdev;
 	struct super_block *sb = fs_info->sb;
 	struct btrfs_fs_devices *fs_devices = fs_info->fs_devices;
-	struct btrfs_fs_devices *seed_devices;
+	struct btrfs_fs_devices *seed_devices = NULL;
 	u64 orig_super_total_bytes;
 	u64 orig_super_num_devices;
 	int ret = 0;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-04-23  9:23 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-03  1:00 linux-next: build warning from Linus' tree Stephen Rothwell
2011-06-03 14:50 ` [PATCH] btrfs: fix uninitialized variable warning David Sterba
2011-06-03 14:56   ` Chris Mason
  -- strict thread matches above, loose matches on Subject: below --
2023-03-24  2:08 Genjian
2023-03-24  2:24 ` Qu Wenruo
2023-03-24  2:29   ` David Sterba
2023-03-24  3:05     ` genjian zhang
2023-03-24  4:24       ` Qu Wenruo
2023-03-24  5:47         ` genjian zhang
2023-04-06 19:12 ` David Sterba
2023-04-23  9:21   ` genjian zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox