From: Connor Hansen <cmdkhh@gmail.com>
To: pjones@redhat.com
Cc: konrad@kernel.org, linux-kernel@vger.kernel.org,
Connor Hansen <cmdkhh@gmail.com>
Subject: [PATCH] iscsi_ibft_find unused variable i
Date: Sun, 5 Jun 2011 03:35:09 -0700 [thread overview]
Message-ID: <1307270109-28635-1-git-send-email-cmdkhh@gmail.com> (raw)
int i is only needed if CONFIG_ACPI is set
so move it within ifdef so kernels without ACPI
dont allocate space for nothing. Fixes warning too.
Signed-off-by: Connor Hansen <cmdkhh@gmail.com>
---
drivers/firmware/iscsi_ibft_find.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
index f032e44..c2bfa50 100644
--- a/drivers/firmware/iscsi_ibft_find.c
+++ b/drivers/firmware/iscsi_ibft_find.c
@@ -108,10 +108,10 @@ done:
*/
unsigned long __init find_ibft_region(unsigned long *sizep)
{
- int i;
ibft_addr = NULL;
#ifdef CONFIG_ACPI
+ int i;
for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++)
acpi_table_parse(ibft_signs[i].sign, acpi_find_ibft);
#endif /* CONFIG_ACPI */
--
1.7.4.4
next reply other threads:[~2011-06-05 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 10:35 Connor Hansen [this message]
2011-06-06 14:06 ` [PATCH] iscsi_ibft_find unused variable i Peter Jones
2011-06-06 15:02 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307270109-28635-1-git-send-email-cmdkhh@gmail.com \
--to=cmdkhh@gmail.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox