From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@suse.de>
Cc: anish <anish198519851985@gmail.com>,
devel@driverdev.osuosl.org, arnd@arndb.de,
lucas.demarchi@profusion.mobi, linux-kernel@vger.kernel.org,
jic23@cam.ac.uk, manuel.stahl@iis.fraunhofer.de
Subject: Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.
Date: Mon, 06 Jun 2011 15:28:29 -0700 [thread overview]
Message-ID: <1307399309.4994.34.camel@Joe-Laptop> (raw)
In-Reply-To: <20110606222118.GA29883@suse.de>
On Mon, 2011-06-06 at 15:21 -0700, Greg KH wrote:
> On Mon, Jun 06, 2011 at 03:10:57PM -0700, Joe Perches wrote:
> > On Mon, 2011-06-06 at 14:55 -0700, Greg KH wrote:
> > > On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote:
> > > > From: anish kumar <anish198519851985@gmail.com>
> > > > Replace kmalloc with local variables as it was un-necessary and
> > > > also removed the redudant code after this change.
> > > SPI data, like USB data, has to come from kmalloced data, not from the
> > > stack, or bad things can, and will, happen.
> > Perhaps just add a comment like:
> > + u8 *tx = kmalloc(2, GFP_KERNEL); /* can't be on stack */
> You really want to do to that for _EVERY_ SPI and USB driver? I don't
> think so.
Nope, only the ones that look especially odd because
kmalloc(sizeof(struct foo), ...)
or
kmalloc(sizeof("type), ...)
is not used.
It might be better to just declare a 2 byte struct.
cheers, Joe
next prev parent reply other threads:[~2011-06-06 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 19:07 [PATCH 1/2] staging: iio replaced kmalloc with local variables anish
2011-06-06 19:13 ` Geert Uytterhoeven
2011-06-06 19:49 ` Dan Carpenter
2011-06-06 19:20 ` Peter Hüwe
2011-06-06 21:55 ` Greg KH
2011-06-06 22:10 ` Joe Perches
2011-06-06 22:21 ` Greg KH
2011-06-06 22:28 ` Joe Perches [this message]
2011-06-06 22:41 ` Greg KH
2011-06-06 22:49 ` Joe Perches
[not found] ` <BANLkTimZP1=tOdsn9eNiERr0Up0xHrr=3g@mail.gmail.com>
2011-06-07 9:43 ` Jonathan Cameron
2011-06-07 10:32 ` anish kumar
2011-06-07 11:23 ` Jonathan Cameron
2011-06-07 9:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307399309.4994.34.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=anish198519851985@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=manuel.stahl@iis.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox