From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: lists@die-jansens.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
stable@kernel.org, tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] lockdep: Fix lock_is_held() on recursion
Date: Tue, 07 Jun 2011 14:39:03 +0200 [thread overview]
Message-ID: <1307450343.2322.250.camel@twins> (raw)
In-Reply-To: <tip-f2513cde93f0957d5dc6c09bc24b0cccd27d8e1d@git.kernel.org>
On Tue, 2011-06-07 at 12:02 +0000, tip-bot for Peter Zijlstra wrote:
> Commit-ID: f2513cde93f0957d5dc6c09bc24b0cccd27d8e1d
> Gitweb: http://git.kernel.org/tip/f2513cde93f0957d5dc6c09bc24b0cccd27d8e1d
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> AuthorDate: Mon, 6 Jun 2011 12:32:43 +0200
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Tue, 7 Jun 2011 12:25:50 +0200
>
> lockdep: Fix lock_is_held() on recursion
>
> The main lock_is_held() user is lockdep_assert_held(), avoid false
> assertions in lockdep_off() sections by unconditionally reporting the
> lock is taken.
>
> [ the reason this is important is a lockdep_assert_held() in ttwu()
> which triggers a warning under lockdep_off() as in printk() which
> can trigger another wakeup and lock up due to spinlock
> recursion, as reported and heroically debugged by Arne Jansen ]
>
> Reported-and-tested-by: Arne Jansen <lists@die-jansens.de>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: <stable@kernel.org>
Not _that_ critical for stable since the offending lockdep_assert_held()
doesn't exist in .39, still definitely won't hurt.
next prev parent reply other threads:[~2011-06-07 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 22:19 [PATCH] lockdep: Fix lock_is_held on recursion Peter Zijlstra
2011-06-07 12:02 ` [tip:sched/urgent] lockdep: Fix lock_is_held() " tip-bot for Peter Zijlstra
2011-06-07 12:39 ` Peter Zijlstra [this message]
2011-06-07 18:06 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307450343.2322.250.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lists@die-jansens.de \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox