From: David Woodhouse <dwmw2@infradead.org>
To: Chris Wright <chrisw@sous-sol.org>
Cc: padmanabh ratnakar <pratnakarlx@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
iommu <iommu@lists.linux-foundation.org>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: Seeing DMAR errors after multiple load/unload with SR-IOV
Date: Tue, 07 Jun 2011 16:33:20 +0100 [thread overview]
Message-ID: <1307460801.24181.51.camel@i7.infradead.org> (raw)
In-Reply-To: <20110607151032.GZ23047@sequoia.sous-sol.org>
On Tue, 2011-06-07 at 08:10 -0700, Chris Wright wrote:
> * David Woodhouse (dwmw2@infradead.org) wrote:
> > On Tue, 2011-06-07 at 06:38 -0700, Chris Wright wrote:
> > > I think we still leak the list entry though. Bottom line is that we
> > > need to handle hotplug ADD_DEVICE and DEL_DEVICE notifications. We
> > > happen to pick up ADD_DEVICE by accident, but it's all pretty sloppy.
> >
> > Yeah, keeping a list of possible stale 'pci_dev' pointers is stupid. We
> > should figure out the matching DMAR unit directly from the ACPI table at
> > ADD_DEVICE time, and store it in pdev->archdata.iommu.
> >
> > I saw patches which were going in that direction...
>
> Cool, where are they? I'm working on something similar, and missed them.
[PATCH] pci, dmar: Update dmar units devices list during hotplug
Alex was working on it.
--
dwmw2
next prev parent reply other threads:[~2011-06-07 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 9:09 Seeing DMAR errors after multiple load/unload with SR-IOV padmanabh ratnakar
2011-06-06 22:17 ` Alex Williamson
2011-06-06 22:34 ` Chris Wright
2011-06-07 6:23 ` padmanabh ratnakar
2011-06-07 13:38 ` Chris Wright
2011-06-07 13:46 ` David Woodhouse
2011-06-07 15:10 ` Chris Wright
2011-06-07 15:33 ` David Woodhouse [this message]
2011-06-07 15:35 ` Chris Wright
2011-06-07 15:40 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307460801.24181.51.camel@i7.infradead.org \
--to=dwmw2@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pratnakarlx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox