From: Johannes Berg <johannes@sipsolutions.net>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dma-debug: print some unfreed allocations
Date: Wed, 08 Jun 2011 13:03:36 +0200 [thread overview]
Message-ID: <1307531016.3961.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20110523123508.GC27867@amd.com>
On Mon, 2011-05-23 at 14:35 +0200, Roedel, Joerg wrote:
> > +#ifdef CONFIG_STACKTRACE
> > + num_show_pending_dent = debugfs_create_u32("num_show_pending", 0644,
> > + dma_debug_dent,
> > + &num_show_pending);
> > + if (!num_show_pending_dent)
> > + goto out_err;
> > +#endif
>
> Hmm, thinking more about this, do we need to introduce a new variable at
> all? It should fit well into the dma-api/all_errors and
> dma-api/num_errors configurables.
I see something similar was merged printing just the first one (and
without stack trace it seems?). Are you still interested in this?
johannes
next prev parent reply other threads:[~2011-06-08 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 18:42 [PATCH] dma-debug: print some unfreed allocations Johannes Berg
2011-05-11 12:47 ` [PATCH v2] " Johannes Berg
2011-05-16 11:00 ` Roedel, Joerg
2011-05-18 22:48 ` Johannes Berg
2011-05-19 8:19 ` Roedel, Joerg
2011-05-20 16:36 ` [PATCH v3] " Johannes Berg
2011-05-23 12:35 ` Roedel, Joerg
2011-06-08 11:03 ` Johannes Berg [this message]
2011-06-08 12:16 ` Roedel, Joerg
2011-06-08 12:26 ` Johannes Berg
2011-06-08 12:37 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307531016.3961.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Joerg.Roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox