public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Phil Oester <kernel@linuxace.com>
To: linux-kernel@vger.kernel.org
Cc: Narendra_K@Dell.com, jordan_hargrave@Dell.com, jbarnes@virtuousgeek.org
Subject: [PATCH] Fix embedded nic order on Dell PowerEdge systems
Date: Wed,  8 Jun 2011 13:14:13 -0700	[thread overview]
Message-ID: <1307564053-2996-1-git-send-email-kernel@linuxace.com> (raw)

    In commit 6e8af08dfa40b747002207d3ce8e8b43a050d99f ("PCI: enable pci=bfsort
    by default on future Dell systems"), the callback added was placed at the
    top of the list, before the specific PowerEdge models.  This ends up
    breaking the more specific models listed, since the new callback handles
    all Dell systems but the older systems don't have the new 0xB1 smbios
    entry.
    
    Fix this by placing the new check _after_ the more specific PowerEdge
    sytems.
    
    Phil Oester
    
    Signed-off-by: Phil Oester <kernel@linuxace.com>

diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
index 5fe7502..92df322 100644
--- a/arch/x86/pci/common.c
+++ b/arch/x86/pci/common.c
@@ -247,13 +247,6 @@ static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = {
 	},
 #endif		/* __i386__ */
 	{
-		.callback = find_sort_method,
-		.ident = "Dell System",
-		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
-		},
-	},
-	{
 		.callback = set_bf_sort,
 		.ident = "Dell PowerEdge 1950",
 		.matches = {
@@ -294,6 +287,13 @@ static const struct dmi_system_id __devinitconst pciprobe_dmi_table[] = {
 		},
 	},
 	{
+		.callback = find_sort_method,
+		.ident = "Dell System",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+		},
+	},
+	{
 		.callback = set_bf_sort,
 		.ident = "HP ProLiant BL20p G3",
 		.matches = {

             reply	other threads:[~2011-06-08 20:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 20:14 Phil Oester [this message]
2011-06-09  8:03 ` [PATCH] Fix embedded nic order on Dell PowerEdge systems Narendra_K
2011-06-09 14:11   ` Phil Oester
2011-07-10  3:32   ` Phil Oester
2011-07-11 12:22     ` Narendra_K
2011-07-22 15:44       ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307564053-2996-1-git-send-email-kernel@linuxace.com \
    --to=kernel@linuxace.com \
    --cc=Narendra_K@Dell.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jordan_hargrave@Dell.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox