public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: David Rientjes <rientjes@google.com>
Cc: Miles Lane <miles.lane@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>,
	John Johansen <john.johansen@canonical.com>
Subject: Re: 3.0.0-rc2-git1 -- BUG: sleeping function called from invalid context at mm/slub.c:847
Date: Wed, 08 Jun 2011 15:17:28 -0500	[thread overview]
Message-ID: <1307564248.4204.1013.camel@calx> (raw)
In-Reply-To: <alpine.DEB.2.00.1106081305430.10320@chino.kir.corp.google.com>

On Wed, 2011-06-08 at 13:09 -0700, David Rientjes wrote:
> On Wed, 8 Jun 2011, Miles Lane wrote:
> 
> > BUG: sleeping function called from invalid context at mm/slub.c:847
> >  in_atomic(): 1, irqs_disabled(): 0, pid: 1583, name: cupsd
> >  2 locks held by cupsd/1583:
> >   #0:  (tasklist_lock){.+.+.+}, at: [<ffffffff8104dafa>] do_prlimit+0x61/0x189
> >   #1:  (&(&p->alloc_lock)->rlock){+.+.+.}, at: [<ffffffff8104db2d>]
> > do_prlimit+0x94/0x189
> >  Pid: 1583, comm: cupsd Not tainted 3.0.0-rc2-git1 #7
> >  Call Trace:
> >   [<ffffffff8102ebf2>] __might_sleep+0x10d/0x112
> >   [<ffffffff810e6f46>] slab_pre_alloc_hook.isra.49+0x2d/0x33
> >   [<ffffffff810e7bc4>] kmem_cache_alloc+0x22/0x132
> >   [<ffffffff8105b6e6>] prepare_creds+0x35/0xe4
> >   [<ffffffff811c0675>] aa_replace_current_profile+0x35/0xb2
> >   [<ffffffff811c4d2d>] aa_current_profile+0x45/0x4c
> >   [<ffffffff811c4d4d>] apparmor_task_setrlimit+0x19/0x3a
> >   [<ffffffff811beaa5>] security_task_setrlimit+0x11/0x13
> >   [<ffffffff8104db6b>] do_prlimit+0xd2/0x189
> >   [<ffffffff8104dea9>] sys_setrlimit+0x3b/0x48
> >   [<ffffffff814062bb>] system_call_fastpath+0x16/0x1b
> > 
> 
> Not sure why this ever actually worked with apparmor if prepare_creds() 
> does an unconditional GFP_KERNEL allocation since this codepath hasn't 
> changed in at least a year and we're holding a spinlock from setrlimit.  
> John?

Probably a lack of people enabling (and using!) both apparmor and
might_sleep. I don't this would be caught by a randconfig boot test.

-- 
Mathematics is the supreme nostalgia of our time.



  reply	other threads:[~2011-06-08 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 19:02 3.0.0-rc2-git1 -- BUG: sleeping function called from invalid context at mm/slub.c:847 Miles Lane
2011-06-08 20:09 ` David Rientjes
2011-06-08 20:17   ` Matt Mackall [this message]
2011-06-08 21:34     ` David Rientjes
2011-06-08 21:57       ` Kyle Moffett
2011-06-08 22:12       ` John Johansen
2011-06-08 22:07   ` John Johansen
2011-06-08 23:47     ` [stable] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307564248.4204.1013.camel@calx \
    --to=mpm@selenic.com \
    --cc=cl@linux-foundation.org \
    --cc=john.johansen@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox