From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Evgeni Golov <sargentd@die-welt.net>
Cc: "ilw@linux.intel.com" <ilw@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlagn: fix *_UCODE_API_MAX output in the firmware field
Date: Sun, 12 Jun 2011 07:44:12 -0700 [thread overview]
Message-ID: <1307889852.13397.128.camel@wwguy-huron> (raw)
In-Reply-To: <1307882071-767-1-git-send-email-sargentd@die-welt.net>
On Sun, 2011-06-12 at 05:34 -0700, Evgeni Golov wrote:
> Currently (3.0-rc2), modinfo iwlagn shows:
> firmware: iwlwifi-5150-IWL5150_UCODE_API_MAX.ucode
> firmware: iwlwifi-5000-IWL5000_UCODE_API_MAX.ucode
> firmware: iwlwifi-6000g2b-IWL6000G2_UCODE_API_MAX.ucode
> firmware: iwlwifi-6000g2a-IWL6000G2_UCODE_API_MAX.ucode
> firmware: iwlwifi-6050-IWL6050_UCODE_API_MAX.ucode
> firmware: iwlwifi-6000-IWL6000_UCODE_API_MAX.ucode
> firmware: iwlwifi-100-IWL100_UCODE_API_MAX.ucode
> firmware: iwlwifi-1000-IWL1000_UCODE_API_MAX.ucode
> firmware: iwlwifi-105-IWL105_UCODE_API_MAX.ucode
> firmware: iwlwifi-2030-IWL2030_UCODE_API_MAX.ucode
> firmware: iwlwifi-2000-IWL2000_UCODE_API_MAX.ucode
>
> which is obviously wrong, the user should not see the *_UCODE_API_MAX
> macros but the actual ucode API versions here.
>
> The problem are the
> #define *_MODULE_FIRMWARE(api) *_FW_PRE #api ".ucode"
> which do not expand api correctly (because this is a macro itself).
>
> Fixed by using __stringify() from linux/stringify.h.
>
> Further information about macro stringification can be found here:
> http://gcc.gnu.org/onlinedocs/cpp/Stringification.html
>
> Signed-off-by: Evgeni Golov <sargentd@die-welt.net>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Good catch, thank you very much
Wey
next prev parent reply other threads:[~2011-06-12 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 12:34 [PATCH] iwlagn: fix *_UCODE_API_MAX output in the firmware field Evgeni Golov
2011-06-12 14:44 ` Guy, Wey-Yi [this message]
2011-06-23 14:31 ` Evgeni Golov
2011-06-23 14:49 ` Guy, Wey-Yi
2011-06-23 15:34 ` John W. Linville
2011-06-23 15:49 ` Guy, Wey-Yi W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307889852.13397.128.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sargentd@die-welt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox