public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Takashi Iwai <tiwai@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] sound: Fix beep_device compilation warnings
Date: Sun, 12 Jun 2011 13:02:43 -0700	[thread overview]
Message-ID: <1307908963.29640.4.camel@Joe-Laptop> (raw)
In-Reply-To: <20110612194037.GA26274@liondog.tnic>

Using static inline functions can reduce compilation messages
and macro misuse.

Signed-off-by: Joe Perches <joe@perches.com>

---

Maybe this helps?

On Sun, 2011-06-12 at 21:40 +0200, Borislav Petkov wrote:
> Btw, I keep noticing those when building on 32bit:
> sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5045’:
> sound/pci/hda/patch_conexant.c:1232:3: warning: statement with no effect
> sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5051’:
> sound/pci/hda/patch_conexant.c:2067:3: warning: statement with no effect
> sound/pci/hda/patch_conexant.c: In function ‘patch_cxt5066’:
> sound/pci/hda/patch_conexant.c:3261:3: warning: statement with no effect
> sound/pci/hda/patch_conexant.c: In function ‘patch_conexant_auto’:
> sound/pci/hda/patch_conexant.c:4370:3: warning: statement with no effect

 sound/pci/hda/hda_beep.h |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_beep.h b/sound/pci/hda/hda_beep.h
index f1de1ba..4967eab 100644
--- a/sound/pci/hda/hda_beep.h
+++ b/sound/pci/hda/hda_beep.h
@@ -50,7 +50,12 @@ int snd_hda_enable_beep_device(struct hda_codec *codec, int enable);
 int snd_hda_attach_beep_device(struct hda_codec *codec, int nid);
 void snd_hda_detach_beep_device(struct hda_codec *codec);
 #else
-#define snd_hda_attach_beep_device(...)		0
-#define snd_hda_detach_beep_device(...)
+static inline int snd_hda_attach_beep_device(struct hda_codec *codec, int nid)
+{
+	return 0;
+}
+void snd_hda_detach_beep_device(struct hda_codec *codec)
+{
+}
 #endif
 #endif



  reply	other threads:[~2011-06-12 20:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-12  7:52 [GIT PULL] sound fixes for 3.0-rc3 Takashi Iwai
2011-06-12 15:50 ` Borislav Petkov
2011-06-12 16:06   ` Takashi Iwai
2011-06-12 16:18     ` Takashi Iwai
2011-06-12 19:40       ` Borislav Petkov
2011-06-12 20:02         ` Joe Perches [this message]
2011-06-13  7:46           ` [PATCH] sound: Fix beep_device compilation warnings Takashi Iwai
2011-06-13  7:45         ` [GIT PULL] sound fixes for 3.0-rc3 Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307908963.29640.4.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=bp@alien8.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox