* [PATCH] irq: Always clear pending flag in check_irq_resend
@ 2011-06-13 0:47 Colin Cross
0 siblings, 0 replies; only message in thread
From: Colin Cross @ 2011-06-13 0:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Colin Cross, Thomas Gleixner
If an interrupt occurs while the irq is masked, the irq is marked
as pending. For a level triggered interrupt, the pending flag
is only cleared when the interrupt is handled. If the interrupt
is never handled because the irq is deasserted before being
enabled it will stay pending, and suspend may be blocked by
check_wakeup_irqs.
Change check_irq_resend to always clear the pending flag,
including for level interrupts.
Signed-off-by: Colin Cross <ccross@android.com>
---
kernel/irq/resend.c | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c
index 14dd576..ef60772 100644
--- a/kernel/irq/resend.c
+++ b/kernel/irq/resend.c
@@ -55,17 +55,18 @@ static DECLARE_TASKLET(resend_tasklet, resend_irqs, 0);
*/
void check_irq_resend(struct irq_desc *desc, unsigned int irq)
{
- /*
- * We do not resend level type interrupts. Level type
- * interrupts are resent by hardware when they are still
- * active.
- */
- if (irq_settings_is_level(desc))
- return;
- if (desc->istate & IRQS_REPLAY)
- return;
if (desc->istate & IRQS_PENDING) {
desc->istate &= ~IRQS_PENDING;
+ /*
+ * We do not resend level type interrupts. Level type
+ * interrupts are resent by hardware when they are still
+ * active.
+ */
+ if (irq_settings_is_level(desc))
+ return;
+ if (desc->istate & IRQS_REPLAY)
+ return;
+
desc->istate |= IRQS_REPLAY;
if (!desc->irq_data.chip->irq_retrigger ||
--
1.7.4.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-13 0:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 0:47 [PATCH] irq: Always clear pending flag in check_irq_resend Colin Cross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox