From: Joe Perches <joe@perches.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Xen-devel] [PATCH 1/2] xen: Add __attribute__((format(printf... where appropriate
Date: Mon, 13 Jun 2011 09:40:31 -0700 [thread overview]
Message-ID: <1307983231.6189.6.camel@Joe-Laptop> (raw)
In-Reply-To: <20110613163158.GA26322@dumpdata.com>
On Mon, 2011-06-13 at 12:31 -0400, Konrad Rzeszutek Wilk wrote:
> On Sun, Jun 12, 2011 at 09:21:13AM -0700, Joe Perches wrote:
> > Use the compiler to verify printf formats and arguments.
> What compiler?
Any supported version of gcc.
> If this is not included in 3.0 what is the fallout?
Nothing of any import.
nodename won't get printed on an unlikely error message.
I don't think it should go into 3.0.
> > err = xenbus_switch_state(dev, XenbusStateConnected);
> > if (err)
> > - xenbus_dev_fatal(dev, err, "switching to Connected state",
> > + xenbus_dev_fatal(dev, err, "%s: switching to Connected state",
> > dev->nodename);
prev parent reply other threads:[~2011-06-13 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 16:21 [PATCH 1/2] xen: Add __attribute__((format(printf... where appropriate Joe Perches
2011-06-12 16:21 ` [PATCH 2/2] block: Add __attribute__((format(printf...) and fix fallout Joe Perches
2011-06-13 8:43 ` Jens Axboe
2011-06-13 16:31 ` [Xen-devel] [PATCH 1/2] xen: Add __attribute__((format(printf... where appropriate Konrad Rzeszutek Wilk
2011-06-13 16:40 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307983231.6189.6.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox