From: Joe Perches <joe@perches.com>
To: "Németh Márton" <nm127@freemail.hu>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Matt Mooney <mfm@muteddisk.com>, Max Vozeler <max@hinterhof.net>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
usbip-devel@lists.sourceforge.net, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] usbip: only dump valid port status
Date: Mon, 13 Jun 2011 14:42:14 -0700 [thread overview]
Message-ID: <1308001334.26699.18.camel@Joe-Laptop> (raw)
In-Reply-To: <4DF68151.4080109@freemail.hu>
On Mon, 2011-06-13 at 23:29 +0200, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> The wIndex parameter of vhci_hub_control() is always zero when the
> request type is GetHubDescriptor,
> ---
> diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
> @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>
> if (usbip_dbg_flag_vhci_rh) {
> pr_debug("port %d\n", rhport);
> - dump_port_status(prev_port_status[rhport]);
> - dump_port_status(dum->port_status[rhport]);
> + /* Only dump valid port status */
> + if (0 <= rhport) {
> + dump_port_status(prev_port_status[rhport]);
> + dump_port_status(dum->port_status[rhport]);
> + }
> }
> usbip_dbg_vhci_rh(" bye\n");
>
Linux relatively rarely uses constant before variable in a comparison.
ie: please use "if (rhport > 0)" instead
next prev parent reply other threads:[~2011-06-13 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 21:29 [PATCH 1/3] usbip: only dump valid port status Németh Márton
2011-06-13 21:42 ` Joe Perches [this message]
2011-06-13 21:47 ` Németh Márton
2011-06-13 22:23 ` Joe Perches
2011-06-14 4:55 ` Németh Márton
2011-07-07 19:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308001334.26699.18.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=max@hinterhof.net \
--cc=mfm@muteddisk.com \
--cc=nm127@freemail.hu \
--cc=sarah.a.sharp@linux.intel.com \
--cc=usbip-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox