From: Joe Perches <joe@perches.com>
To: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
Cc: "David S. Miller" <davem@davemloft.net>,
David Decotigny <decot@google.com>,
"Hans J. Koch" <hjk@linutronix.de>, Jiri Kosina <jkosina@suse.cz>,
Ben Pfaff <blp@cs.stanford.edu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
christian.dietrich@informatik.uni-erlangen.de
Subject: Re: [PATCH 06/11] drivers/net: use printk_ratelimited() instead of printk_ratelimit()
Date: Thu, 16 Jun 2011 09:43:52 -0700 [thread overview]
Message-ID: <1308242632.9563.12.camel@Joe-Laptop> (raw)
In-Reply-To: <bbe5954082599bcf65e9fdf565df8b9646ec3e3b.1308142053.git.manuel.f.zerpies@ww.stud.uni-erlangen.de>
On Thu, 2011-06-16 at 14:12 +0200, Manuel Zerpies wrote:
> Since printk_ratelimit() shouldn't be used anymore (see comment in
> include/linux/printk.h), replace it with printk_ratelimited()
[]
> diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
[]
> @@ -536,8 +537,7 @@ static bool _sc92031_check_media(struct net_device *dev)
>
> netif_carrier_on(dev);
>
> - if (printk_ratelimit())
> - printk(KERN_INFO "%s: link up, %sMbps, %s-duplex\n",
> + printk_ratelimited(KERN_INFO "%s: link up, %sMbps, %s-duplex\n",
> dev->name,
> speed_100 ? "100" : "10",
> duplex_full ? "full" : "half");
All these might be better using net_ratelimit and netdev_<level>
if (net_ratelimit())
netdev_info(dev, "link up, %uMbps, %s-duplex\n",
speed_100 ? 100 : 10,
duplex_full ? "full" : "half");
> @@ -549,8 +549,7 @@ static bool _sc92031_check_media(struct net_device *dev)
>
> _sc92031_disable_tx_rx(dev);
>
> - if (printk_ratelimit())
> - printk(KERN_INFO "%s: link down\n", dev->name);
> + printk_ratelimited(KERN_INFO "%s: link down\n", dev->name);
etc...
netdev_<level>_ratelimited (and netdev_<level>_once)
could instead be added and used I suppose.
next prev parent reply other threads:[~2011-06-16 16:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1308142053.git.manuel.f.zerpies@ww.stud.uni-erlangen.de>
2011-06-16 12:06 ` [PATCH 01/11] drivers/ide: use printk_ratelimited() instead of printk_ratelimit() Manuel Zerpies
2011-06-16 14:19 ` Borislav Petkov
2011-06-20 8:17 ` Manuel Zerpies
2011-06-20 8:22 ` Sergei Shtylyov
2011-06-16 14:32 ` Sergei Shtylyov
2011-06-16 12:07 ` [PATCH 02/11] drivers/tty: " Manuel Zerpies
2011-06-16 12:08 ` [PATCH 03/11] net/can: " Manuel Zerpies
2011-06-17 4:03 ` David Miller
2011-06-16 12:09 ` [PATCH 04/11] net/rds: use prink_ratelimited() " Manuel Zerpies
2011-06-17 4:03 ` David Miller
2011-06-16 12:10 ` [PATCH 05/11] RDMA/hw/cxgb4: use printk_ratelimited() " Manuel Zerpies
2011-07-19 4:19 ` Roland Dreier
2011-06-16 12:12 ` [PATCH 06/11] drivers/net: " Manuel Zerpies
2011-06-16 16:43 ` Joe Perches [this message]
2011-06-16 12:12 ` [PATCH 07/11] drivers/usb/atm: " Manuel Zerpies
2011-06-16 14:37 ` Sergei Shtylyov
2011-06-16 12:13 ` [PATCH 08/11] [SCSI] tcm_fc: " Manuel Zerpies
2011-06-16 12:14 ` [PATCH 09/11] xen/xenbus: " Manuel Zerpies
2011-06-16 21:00 ` Jeremy Fitzhardinge
2011-06-16 23:44 ` Joe Perches
2011-06-16 12:15 ` [PATCH 10/11] wusb: " Manuel Zerpies
2011-06-16 14:34 ` Sergei Shtylyov
2011-06-16 12:15 ` [PATCH 11/11] usb/class: " Manuel Zerpies
2011-06-16 15:36 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308242632.9563.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=blp@cs.stanford.edu \
--cc=christian.dietrich@informatik.uni-erlangen.de \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=hjk@linutronix.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.f.zerpies@ww.stud.uni-erlangen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox