linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <levinsasha928@gmail.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	Pekka Enberg <penberg@kernel.org>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Avi Kivity <avi@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Prasad Joshi <prasadjoshi124@gmail.com>,
	Cyrill Gorcunov <gorcunov@gmail.com>,
	Asias He <asias.hejun@gmail.com>
Subject: Re: [ANNOUNCE] Native Linux KVM tool v2
Date: Fri, 17 Jun 2011 09:41:13 -0400	[thread overview]
Message-ID: <1308318073.8711.7.camel@lappy> (raw)
In-Reply-To: <BANLkTimVG4GVoar6RHYRpdiDngCC+9rHTg@mail.gmail.com>

On Fri, 2011-06-17 at 06:00 +0100, Stefan Hajnoczi wrote:
> On Fri, Jun 17, 2011 at 2:03 AM, Sasha Levin <levinsasha928@gmail.com> wrote:
> > On Thu, 2011-06-16 at 17:50 -0500, Anthony Liguori wrote:
> >> On 06/16/2011 09:48 AM, Pekka Enberg wrote:
> >> > On Wed, Jun 15, 2011 at 6:53 PM, Pekka Enberg<penberg@kernel.org>  wrote:
> >> >> - Fast QCOW2 image read-write support beating Qemu in fio benchmarks. See the
> >> >>   following URL for test result details: https://gist.github.com/1026888
> >> >
> >> > It turns out we were benchmarking the wrong guest kernel version for
> >> > qemu-kvm which is why it performed so much worse. Here's a summary of
> >> > qemu-kvm beating tools/kvm:
> >> >
> >> > https://raw.github.com/gist/1029359/9f9a714ecee64802c08a3455971e410d5029370b/gistfile1.txt
> >> >
> >> > I'd ask for a brown paper bag if I wasn't so busy eating my hat at the moment.
> >>
> >> np, it happens.
> >>
> >> Is that still with QEMU with IDE emulation, cache=writethrough, and
> >> 128MB of guest memory?
> >>
> >> Does your raw driver support multiple parallel requests?  It doesn't
> >> look like it does from how I read the code.  At some point, I'd be happy
> >> to help ya'll do some benchmarking against QEMU.
> >>
> >
> > Each virtio-blk device can process requests regardless of other
> > virtio-blk devices, which means that we can do parallel requests for
> > devices.
> >
> > Within each device, we support parallel requests in the sense that we do
> > vectored IO for each head (which may contain multiple blocks) in the
> > vring, we don't do multiple heads because when I've tried adding AIO
> > I've noticed that at most there are 2-3 possible heads - and since it
> > points to the same device it doesn't really help running them in
> > parallel.
> 
> One thing that QEMU does but I'm a little suspicious of is request
> merging.  virtio-blk will submit those 2-3 heads using
> bdrv_aio_multiwrite() if they become available in the same virtqueue
> notify.  The requests will be merged if possible.
> 
> My feeling is that we should already have merged requests coming
> through virtio-blk and there should be no need to do any merging -
> which could be a workaround for a poor virtio-blk vring configuration
> that prevented the guest from sending large requests.  However, this
> feature did yield performance improvements with qcow2 image files when
> it was introduced, so that would be interesting to look at.
> 
> Are you enabling indirect descriptors on the virtio-blk vring?  That
> should allow more requests to be made available because you don't run
> out of vring descriptors so easily.

No, but we're usually not getting close to running out of vring
descriptors either.

-- 

Sasha.


  reply	other threads:[~2011-06-17 13:41 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 15:53 [ANNOUNCE] Native Linux KVM tool v2 Pekka Enberg
2011-06-15 16:30 ` Avi Kivity
2011-06-15 17:10   ` Pekka Enberg
2011-06-15 20:13     ` Prasad Joshi
2011-06-15 20:23       ` Sasha Levin
2011-06-15 20:49         ` Prasad Joshi
2011-06-15 21:53       ` Anthony Liguori
2011-06-15 22:04       ` Anthony Liguori
2011-06-15 22:07         ` Alexander Graf
2011-06-15 22:20           ` Anthony Liguori
2011-06-15 22:44             ` Anthony Liguori
2011-06-16  5:41               ` Pekka Enberg
2011-06-16  6:21                 ` Pekka Enberg
2011-06-16  9:24                   ` Christoph Hellwig
2011-06-16  9:34                     ` Pekka Enberg
2011-06-16  9:48                       ` Christoph Hellwig
2011-06-16  9:57                         ` Ingo Molnar
2011-06-16  9:57                         ` Pekka Enberg
2011-06-16 10:02                           ` Christoph Hellwig
2011-06-16 11:22                             ` Ingo Molnar
2011-06-16 11:25                               ` Christoph Hellwig
2011-06-16 11:40                                 ` Ingo Molnar
2011-06-16 11:51                                   ` Christoph Hellwig
2011-06-17  7:21                               ` Jeff Garzik
2011-06-16  5:45           ` Pekka Enberg
2011-06-16  7:24             ` Ingo Molnar
2011-06-16  7:33               ` Pekka Enberg
2011-06-16  8:07                 ` Ingo Molnar
2011-06-16  9:09               ` Stefan Hajnoczi
2011-06-16  5:29         ` Stefan Hajnoczi
2011-06-16  5:42           ` Pekka Enberg
2011-06-15 21:41 ` Anthony Liguori
2011-06-16 14:28 ` Michael S. Tsirkin
2011-06-16 15:01   ` Asias He
2011-06-19  8:15     ` Michael S. Tsirkin
2011-06-16 14:48 ` Pekka Enberg
2011-06-16 22:50   ` Anthony Liguori
2011-06-17  1:03     ` Sasha Levin
2011-06-17  5:00       ` Stefan Hajnoczi
2011-06-17 13:41         ` Sasha Levin [this message]
2011-06-17 13:45       ` Anthony Liguori
2011-06-17  5:11   ` Stefan Hajnoczi
2011-06-17  7:31 ` justin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308318073.8711.7.camel@lappy \
    --to=levinsasha928@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anthony@codemonkey.ws \
    --cc=asias.hejun@gmail.com \
    --cc=avi@redhat.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    --cc=stefanha@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).