The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Daniel J Blueman <daniel.blueman@gmail.com>
To: Eric Anholt <eric@anholt.net>, Dave Airlie <airlied@redhat.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Ben Widawsky <ben@bwidawsk.net>,
	Kenneth Graunke <kenneth@whitecape.org>,
	Yi Sun <yi.sun@intel.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	Mengmeng Meng <mengmeng.meng@intel.com>,
	Robert Hooker <sarvatt@ubuntu.com>,
	Daniel J Blueman <daniel.blueman@gmail.com>
Subject: [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling
Date: Sat, 18 Jun 2011 00:42:00 +0800	[thread overview]
Message-ID: <1308328920-2068-1-git-send-email-daniel.blueman@gmail.com> (raw)

Workaround Sandy Bridge GPU stalls by allowing the blitter command streamer
to write interrupt state to the Hardware Status Page when a MI_USER_INTERRUPT
command is decoded.

v1->v2: Moved to prior interrupt handler installation and RMW flags as per
feedback.

Eric, if you're happy, please sign-off and send to Dave for inclusion in -rc4
if possible. Further changes may be needed for -stable.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
---
 drivers/gpu/drm/i915/i915_irq.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index b9fafe3..b7f11a5 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1741,6 +1741,13 @@ void ironlake_irq_preinstall(struct drm_device *dev)
 
 	I915_WRITE(HWSTAM, 0xeffe);
 
+	if (IS_GEN6(dev))
+		/* workaround stalls observed on Sandy Bridge GPUs by
+		   allowing the blitter command streamer to generate a
+		   write to the Hardware Status Page for MI_USER_INTERRUPT */
+		I915_WRITE(GEN6_BLITTER_HWSTAM, I915_READ(GEN6_BLITTER_HWSTAM)
+			& ~GEN6_BLITTER_USER_INTERRUPT);
+
 	/* XXX hotplug from PCH */
 
 	I915_WRITE(DEIMR, 0xffffffff);
-- 
1.7.4.1


             reply	other threads:[~2011-06-17 16:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 16:42 Daniel J Blueman [this message]
2011-06-17 17:44 ` [PATCH 3.0-rc3, v2] i915: Fix gen6 (SNB) GPU stalling Eric Anholt
2011-06-17 18:20   ` Daniel J Blueman
2011-06-17 20:39     ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308328920-2068-1-git-send-email-daniel.blueman@gmail.com \
    --to=daniel.blueman@gmail.com \
    --cc=airlied@redhat.com \
    --cc=ben@bwidawsk.net \
    --cc=chris@chris-wilson.co.uk \
    --cc=eric@anholt.net \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kenneth@whitecape.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mengmeng.meng@intel.com \
    --cc=sarvatt@ubuntu.com \
    --cc=yi.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox