Re: [PATCH 1/1] HWMON: TMP102 - Added support for 12 bit data

Jean Delvare
2011-06-23T08:45:35Z

On Thu, 23 Jun 2011 13:56:53 +0530, Ankur Patel wrote:
> On Thu, Jun 23, 2011 at 1:36 PM, Jean Delvare <khali@linux-fr.org> wrote:
>
> > On Wed, 22 Jun 2011 07:51:39 +0530, Ankur Patel wrote:
> > > From: Ankur Patel <ankur.patel@quipment.in>
> > >
> > > In the tmp102.ko driver support for 12 bit data is added. Also, the
> > > sysfs names are replaced with the actual chip supported fuctionality
> > > names.
> >
> > Nack. These attribute names are standard, see
> > Documentation/hwmon/sysfs-interface. You don't get to change them.
> >
> >
> > What problem were you trying to solve? libsensors expects the attribute
> > names which are in use today.
> >
> > Agree, But using temp1_max_hyst as an attribute for presenting low level
> threshold, will it not more feasible to use temp1_low instead?.

No. This isn't a min temperature limit. Please read the TMP102
datasheet and in particular Figure 10 "Output Transfer Function
Diagrams" and the description of the AL configuration bit.

--
Jean Delvare