Re: [34-longterm 029/247] iwlagn: enable only rfkill interrupt when device is down

Stanislaw Gruszka
2011-06-24T08:15:17Z

On Thu, Jun 23, 2011 at 01:17:52PM -0400, Paul Gortmaker wrote:
> From: Stanislaw Gruszka <sgruszka@redhat.com>
>
> -------------------
> This is a commit scheduled for the next v2.6.34 longterm release.
> If you see a problem with using this for longterm, please comment.
> -------------------
>
> commit 554d1d027b19265c4aa3f718b3126d2b86e09a08 upstream.
>
> Since commit 6cd0b1cb872b3bf9fc5de4536404206ab74bafdd "iwlagn: fix
> hw-rfkill while the interface is down", we enable interrupts when
> device is not ready to receive them. However hardware, when it is in
> some inconsistent state, can generate other than rfkill interrupts
> and crash the system. I can reproduce crash with "kernel BUG at
> drivers/net/wireless/iwlwifi/iwl-agn.c:1010!" message, when forcing
> firmware restarts.
>
> To fix only enable rfkill interrupt when down device and after probe.
> I checked patch on laptop with 5100 device, rfkill change is still
> passed to user space when device is down.

This needs follow up:

commit 3dd823e6b86407aed1a025041d8f1df77e43a9c8
Author: Don Fry <donald.h.fry@intel.com>
Date: Sun Feb 6 09:29:45 2011 -0800

iwlagn: Re-enable RF_KILL interrupt when down

I'm not sure if that commit is included in the patch series.

Stanislaw