Re: [Stable-review] [34-longterm 224/247] fs/partitions/ldm.c: fix oops caused by corrupted partition table

Paul Gortmaker
2011-06-24T12:13:31Z

On 11-06-23 07:14 PM, Ben Hutchings wrote:
> On Thu, 2011-06-23 at 13:34 -0400, Paul Gortmaker wrote:
>> From: Timo Warns <Warns@pre-sense.de>
>>
>> -------------------
>> This is a commit scheduled for the next v2.6.34 longterm release.
>> If you see a problem with using this for longterm, please comment.
>> -------------------
>>
>> commit c340b1d640001c8c9ecff74f68fd90422ae2448a upstream.
>>
>> The kernel automatically evaluates partition tables of storage devices.
>> The code for evaluating LDM partitions (in fs/partitions/ldm.c) contains
>> a bug that causes a kernel oops on certain corrupted LDM partitions.
>> A kernel subsystem seems to crash, because, after the oops, the kernel no
>> longer recognizes newly connected storage devices.
>>
>> The patch validates the value of vblk_size.
> [...]
>
> This doesn't completely fix the possibility of a buffer overflow. You
> also need commit cae13fe4cc3f24820ffb990c09110626837e85d4.

Thanks Ben, I will queue that up this morning.

Paul.

>
> Ben.
>