Re: [34-longterm 024/247] USB: prevent buggy hubs from crashing the USB stack

Paul Gortmaker
2011-06-23T19:59:47Z

On Thu, Jun 23, 2011 at 2:48 PM, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Thu, 23 Jun 2011, Paul Gortmaker wrote:
>
>> From: Alan Stern <stern@rowland.harvard.edu>
>>
>>                    -------------------
>>     This is a commit scheduled for the next v2.6.34 longterm release.
>>     If you see a problem with using this for longterm, please comment.
>>                    -------------------
>>
>> commit d199c96d41d80a567493e12b8e96ea056a1350c1 upstream.
>>
>> If anyone comes across a high-speed hub that (by mistake or by design)
>> claims to have no Transaction Translators, plugging a full- or
>> low-speed device into it will cause the USB stack to crash.  This
>> patch (as1446) prevents the problem by ignoring such devices, since
>> the kernel has no way to communicate with them.
>
> This commit had some unexpected fallout.  It shouldn't be merged unless
> the following upstream commits are also merged:
>
> c5c69f3f0dcf9b569c8f3ad67f3af92cfcedac43
> cee6a262550f53a13acfefbc1e3e5ff35c96182c
> ec95d35a6bd0047f05fe8a21e6c52f8bb418da55

Thanks Alan, I'll sort this out and the Nvidia one. Greg, it looks like
you have two and three in 32.40, but not #1 (c5c69f) queued up, in
case that saves you looking.

P.

>
> Alan Stern
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>