public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Don Zickus <dzickus@redhat.com>
Cc: eranian@google.com, fweisbec@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: x86, perf, pmu: make reserve_ds_buffers() allocate memory dynamically
Date: Tue, 28 Jun 2011 12:38:01 +0200	[thread overview]
Message-ID: <1309257481.6701.192.camel@twins> (raw)
In-Reply-To: <20110624160143.GA29969@redhat.com>

On Fri, 2011-06-24 at 12:01 -0400, Don Zickus wrote:
> Hi guys,
> 
> Some kdump folks noticed that on large machines (say 80 cpu threads), the
> kernel reserved a good chunk of memory in the kdump kernel with the call
> to reserve_ds_buffers(). About 64k per cpu.
> 
> Normally the kdump kernel boots with maxcpus=1 to limit the amount of
> processing and memory usage it needs.  However, with reserve_ds_buffers()
> it seems to allocate a giant chunk of memory due to its use of
> for_each_possible_cpu().
> 
> I was wondering if it was possible to move some of that allocation to the
> cpu_prepare/cpu_starting routines and allocate during a cpu hotplug event.
> I am not sure if some of this allocation is on a per cpu basis (which
> includes multiple cores) or if there is some sort of other restriction
> that required the code to be statically allocated at boot time.

The only complication I can remember is that the BTS buffers are an
order 4 allocation, so the later you allocate them the less likely they
are to be available.

Other than that there isn't anything magical about any of it.

      reply	other threads:[~2011-06-28 10:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 16:01 x86, perf, pmu: make reserve_ds_buffers() allocate memory dynamically Don Zickus
2011-06-28 10:38 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309257481.6701.192.camel@twins \
    --to=peterz@infradead.org \
    --cc=dzickus@redhat.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox