From: Joe Perches <joe@perches.com>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: ioctl: Fix coding style issues
Date: Fri, 01 Jul 2011 02:58:19 -0700 [thread overview]
Message-ID: <1309514299.7277.30.camel@Joe-Laptop> (raw)
In-Reply-To: <1309513472-30687-1-git-send-email-chrisf@ijw.co.nz>
On Fri, 2011-07-01 at 21:44 +1200, Chris Forbes wrote:
> Fixed issues as flagged by checkpatch.pl
> diff --git a/block/ioctl.c b/block/ioctl.c
[]
> @@ -6,10 +6,10 @@
> #include <linux/backing-dev.h>
> #include <linux/buffer_head.h>
> #include <linux/blktrace_api.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>
>
> -static int blkpg_ioctl(struct block_device *bdev, struct blkpg_ioctl_arg __user *arg)
> -{
> +static int blkpg_ioctl(struct block_device *bdev,
> + struct blkpg_ioctl_arg __user *arg) {
Hey Chris.
Sorry, that's not right.
The open brace needs to be on a new line.
next prev parent reply other threads:[~2011-07-01 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 9:09 [PATCH] block: ioctl: Fix coding style issues Chris Forbes
2011-07-01 9:16 ` Chris Forbes
2011-07-01 9:44 ` [PATCH v2] " Chris Forbes
2011-07-01 9:58 ` Joe Perches [this message]
2011-07-01 10:08 ` [PATCH v3] block: ioctl: Fixed " Chris Forbes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309514299.7277.30.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=chrisf@ijw.co.nz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox