From: Joe Perches <joe@perches.com>
To: netdev <netdev@vger.kernel.org>
Cc: Cong Wang <amwang@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [rfc] Remove member .name from struct netpoll
Date: Fri, 01 Jul 2011 10:07:51 -0700 [thread overview]
Message-ID: <1309540071.7277.63.camel@Joe-Laptop> (raw)
struct netpoll has member .name
struct netpoll {
struct net_device *dev;
char dev_name[IFNAMSIZ];
const char *name;
[...]
};
that is set only by netconsole.c
static struct netconsole_target *alloc_param_target(char *target_config)
{
[...]
nt->np.name = "netconsole";
and used only by net/core/netpoll.c to emit "netconsole: " on
logging messages.
e.g.
void netpoll_print_options(struct netpoll *np)
{
printk(KERN_INFO "%s: local port %d\n",
np->name, np->local_port);
I think it'd be more common to use pr_fmt and pr_<level>
to emit these logging messages.
Are there out of tree users or plans to use "struct netpoll"
by other modules?
If not, I propose to remove name from the struct.
next reply other threads:[~2011-07-01 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 17:07 Joe Perches [this message]
2011-07-04 2:07 ` [rfc] Remove member .name from struct netpoll Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309540071.7277.63.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox