From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: amwang@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/2] netpoll: Trivial updates
Date: Fri, 01 Jul 2011 15:18:23 -0700 [thread overview]
Message-ID: <1309558703.7277.78.camel@Joe-Laptop> (raw)
In-Reply-To: <20110701.000646.268663722441785795.davem@davemloft.net>
On Fri, 2011-07-01 at 00:06 -0700, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> >>> BTW, you can kill the export of netpoll_send_skb_on_dev() too.
> >> Not too sure about that.
> >> It's used in netpoll.h by netpoll_send_skb.
> >> It could be called from anywhere.
> >> It's currently called/used by bonding.h.
> > % git grep netpoll_send_skb_on_dev .
[]
> > No modules use it...
> Right, this is a relic that bonding was using at one point
> in the past but it no longer does.
Are you sure?
netpoll.h:
void netpoll_send_skb_on_dev(struct netpoll *np, struct sk_buff *skb,
struct net_device *dev);
static inline void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
{
netpoll_send_skb_on_dev(np, skb, np->dev);
}
$ grep -rP --include=*.[ch] -w netpoll_send_skb *
drivers/net/bonding/bonding.h: netpoll_send_skb(np, skb);
include/linux/netpoll.h:static inline void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
net/bridge/br_private.h: netpoll_send_skb(np, skb);
net/core/netpoll.c: "netpoll_send_skb(): %s enabled interrupts in poll (%pF)\n",
net/core/netpoll.c: netpoll_send_skb(np, skb);
net/core/netpoll.c: netpoll_send_skb(np, send_skb);
from bonding.h
#ifdef CONFIG_NET_POLL_CONTROLLER
static inline void bond_netpoll_send_skb(const struct slave *slave,
struct sk_buff *skb)
{
struct netpoll *np = slave->np;
if (np)
netpoll_send_skb(np, skb);
}
and br_private.h
static inline void br_netpoll_send_skb(const struct net_bridge_port *p,
struct sk_buff *skb)
{
struct netpoll *np = p->np;
if (np)
netpoll_send_skb(np, skb);
}
These are inlined and dependent on CONFIG_NET_POLL_CONTROLLER
in drivers/net/Kconfig so doesn't netpoll_send_skb_on_dev need
to be SYMBOL_EXPORTed?
cheers, Joe
next prev parent reply other threads:[~2011-07-01 22:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 1:08 [PATCH 0/2] netpoll: Trivial updates Joe Perches
2011-07-01 1:08 ` [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-04 6:53 ` Harry Wei
2011-07-04 7:46 ` Joe Perches
2011-07-04 9:27 ` Harry Wei
2011-07-01 1:08 ` [PATCH 2/2] netpoll: Remove wrapper function netpoll_poll Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-01 3:26 ` [PATCH 0/2] netpoll: Trivial updates Cong Wang
2011-07-01 3:35 ` Joe Perches
2011-07-01 3:49 ` Cong Wang
2011-07-01 3:55 ` Joe Perches
2011-07-01 4:00 ` Cong Wang
2011-07-01 4:03 ` Joe Perches
2011-07-01 4:05 ` Cong Wang
2011-07-01 7:06 ` David Miller
2011-07-01 22:18 ` Joe Perches [this message]
2011-07-01 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309558703.7277.78.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox