public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Ram Pai <linuxram@us.ibm.com>
Cc: jbarnes@virtuousgeek.org, torvalds@linux-foundation.org,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	yinghai@kernel.org, socketcan@hartkopp.net, bhelgaas@google.com,
	linux@dominikbrodowski.net
Subject: Re: [PATCH 0/5 v2] PCI: fix cardbus and sriov regressions
Date: Sat, 02 Jul 2011 00:07:48 +0100	[thread overview]
Message-ID: <1309561669.2693.20.camel@bwh-desktop> (raw)
In-Reply-To: <1309477662-18680-1-git-send-email-linuxram@us.ibm.com>

On Thu, 2011-06-30 at 16:47 -0700, Ram Pai wrote:
> The following patch-set fixes regressions caused by:
> 
> the commit "PCI: update bridge resources to get more big ranges when allocating space (again)"
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=da7822e5ad71ec9b745b412639f1e5e0ba795a20
> 
> patch 1/5: fix calculation of additional resource size for hotplug bridges
> patch 2/5: ability to resize assigned pci-resource
> patch 3/5: make SRIOV BARs resources optional
> patch 4/5: make cardbus bridge resources optional
> patch 5/5: code and terminology cleanup
> 
> The regression was caused on some platforms with limited i/o and memory
> resources, the optional resources were allocated ahead of required resources,
> thus starving the latter. The patchset ensures that all the required resources
> are satisfied before any optional resources are satisfied.

This certainly fixes the problem I originally reported: all the basic
BARs for devices with SR-IOV enabled are mapped.

When testing this, I noticed that a BAR which we fail to allocate space
for may be left configured with an address range that overlaps that of
other BARs.  However, that does not appear to be a regression.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  parent reply	other threads:[~2011-07-01 23:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 23:47 [PATCH 0/5 v2] PCI: fix cardbus and sriov regressions Ram Pai
2011-06-30 23:47 ` [PATCH 1/5 v2] PCI: honor child buses optional size in hot plug configuration Ram Pai
2011-06-30 23:47 ` [PATCH 2/5 v2] PCI : ability to relocate assigned pci-resources Ram Pai
2011-06-30 23:47 ` [PATCH 3/5 v2] PCI: make SRIOV resources optional Ram Pai
2011-07-01  6:01   ` Oliver Hartkopp
2011-07-06 17:48     ` Jesse Barnes
2011-07-07 15:34       ` Oliver Hartkopp
2011-06-30 23:47 ` [PATCH 4/5 v2] PCI: make cardbus-bridge " Ram Pai
2011-06-30 23:47 ` [PATCH 5/5 v2] PCI: code and terminology cleanup Ram Pai
2011-07-01 23:07 ` Ben Hutchings [this message]
2011-07-02 13:04   ` [PATCH 0/5 v2] PCI: fix cardbus and sriov regressions Ram Pai
2011-07-04 23:35     ` Ben Hutchings
2011-07-03 21:30 ` Linus Torvalds
2011-07-04  3:55   ` Harry Wei
2011-07-06  8:53   ` Ram Pai
2011-07-06 17:46     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309561669.2693.20.camel@bwh-desktop \
    --to=bhutchings@solarflare.com \
    --cc=bhelgaas@google.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=linuxram@us.ibm.com \
    --cc=socketcan@hartkopp.net \
    --cc=torvalds@linux-foundation.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox