From: Ravishankar <ravishankarkm32@gmail.com>
To: gregkh@suse.de, wfp5p@virginia.edu
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ravishankar <ravi.shankar@greenturtles.in>,
Ravishankar <ravishankarkm32@gmail.com>
Subject: [PATCH 2/2] Staging: comedi: fix WARNING issue in icp_multi.c
Date: Wed, 6 Jul 2011 12:03:46 +0530 [thread overview]
Message-ID: <1309934026-2677-1-git-send-email-ravishankarkm32@gmail.com> (raw)
In-Reply-To: <[PATCH]Staging: comedi: fix tab space warning issues in icp_multi.c>
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the icp_multi.c file that fixes up a WARNING found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/icp_multi.c | 13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/icp_multi.c b/drivers/staging/comedi/drivers/icp_multi.c
index 126550f..78f33e7 100644
--- a/drivers/staging/comedi/drivers/icp_multi.c
+++ b/drivers/staging/comedi/drivers/icp_multi.c
@@ -59,13 +59,12 @@ Options:
#include "icp_multi.h"
#define DEVICE_ID 0x8000 /* Device ID */
+#define ICP_MULTI_EXTDEBUG /* */
-#define ICP_MULTI_EXTDEBUG
+/* Hardware types of the cards */
+#define TYPE_ICP_MULTI 0
-/* Hardware types of the cards */
-#define TYPE_ICP_MULTI 0
-
-#define IORANGE_ICP_MULTI 32
+#define IORANGE_ICP_MULTI 32
#define ICP_MULTI_ADC_CSR 0 /* R/W: ADC command/status register */
#define ICP_MULTI_AI 2 /* R: Analogue input data */
@@ -572,7 +571,7 @@ static int icp_multi_insn_bits_do(struct comedi_device *dev,
s->state &= ~data[0];
s->state |= (data[0] & data[1]);
- printk(KERN_DEBUG "Digital outputs = %4x \n", s->state);
+ printk(KERN_DEBUG "Digital outputs = %4x\n", s->state);
writew(s->state, devpriv->io_addr + ICP_MULTI_DO);
}
@@ -966,7 +965,7 @@ static int icp_multi_attach(struct comedi_device *dev,
devpriv->phys_iobase = iobase;
printk(KERN_WARNING
- ", b:s:f=%d:%d:%d, io=0x%8llx \n", pci_bus, pci_slot, pci_func,
+ ", b:s:f=%d:%d:%d, io=0x%8llx\n", pci_bus, pci_slot, pci_func,
(unsigned long long)iobase);
devpriv->io_addr = ioremap(iobase, ICP_MULTI_SIZE);
--
1.7.1.1
next parent reply other threads:[~2011-07-06 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH]Staging: comedi: fix tab space warning issues in icp_multi.c>
2011-07-06 6:33 ` Ravishankar [this message]
2011-07-06 15:59 ` [PATCH 2/2] Staging: comedi: fix WARNING issue in icp_multi.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309934026-2677-1-git-send-email-ravishankarkm32@gmail.com \
--to=ravishankarkm32@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravi.shankar@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox