From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750867AbdAWKA0 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 05:00:26 -0500
Received: from mout.web.de ([217.72.192.78]:63907 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750724AbdAWKAY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 05:00:24 -0500
Subject: Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable
 "ret" in tg_set_max()
To: Johannes Thumshirn <jthumshirn@suse.de>, linux-block@vger.kernel.org
References: <e734cafa-eec0-9d5b-b368-2de496a96c80@users.sourceforge.net>
 <75495d45-cfc4-9740-39e4-bd4c3e71232b@users.sourceforge.net>
 <20170123091510.GA3517@linux-x5ow.site>
Cc: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <130ce081-e9a2-4744-c74b-b73bea5ae98c@users.sourceforge.net>
Date: Mon, 23 Jan 2017 11:00:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170123091510.GA3517@linux-x5ow.site>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:lrZvFAF88OzY6m6tTe7F/Uv9o1B/7Io4+KFVOEyNUy+6MvxeICB
 hdXGkMDuz62G3C11OWVdRDXnik1FCK4juaNZxBEZ+gzZv0dB/9F6e/SFxAVHW+/q/SXxuWa
 gCf6tJwigHkqH377RoOxYdNUW+xaxAFJd/ZtqkclE5XoSNz3lzZiJvCyLHY2d15/quxj41S
 fr3hQIwZNKz2UsevcUPHw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:y2oaOqS/mYo=:jXgkyzFSOG2bxtRysmLw4Y
 oAtn0txNdldZuXxZ4tclx+F61VDCIiC2xZbAIi9N36dYuD4Dhii++2zz4Bxynb0GVPMHP+xUz
 R9Hk5kdjGrZ9+rut4IWmYdTRv4IZUZ8tA3DhdLKKXnvAKJag99Es5sNJ6Nr8lOCnrn3YZWTWL
 gWkLbPePpaMeVkv+3oTbIO2rdcr/69smMDRodtqmPnVkGfmWeJUH8LOEJnmXacLbG4s3aDIn4
 l0bzxdWHRQiyGy99i1HrMWZCiAUF+9mneqy4sRluZaiqBtW40LlEGXCDpXaNKnoSp3oN/nORn
 7qNBsIlz7c+kNuQGPVDcuFTbA/hjGBUZpigo0I/E8uqj1q1IPv15JHdx8J54jUHpw38gzkVOE
 qpEb2MLf9je/kEVT9QWn9SWhHZKIauEITnGtrwoYc0XDuuUBSk7FTfN3RU9RYxrPdRbRtf/0w
 o00owRL3R1hGOo/QIqtisSlwXDs8NVAGLgml++m69ljxuz9LGELRPVl3JGOQEYFQjRBUsJMwD
 pE9B/OZ3/Mz4cyW0vUjun7e0qZGmB956EDfvLMYwTTDCoOYgzlkMwy0amhJGxxW9La6vc5Qa6
 NHT46Rk9B6FwWwtWo3UfkwKdGKrP8CTi9VY7FAvA5EEOpEKagRZdd+e5ZbgqcK9B41hzkXvto
 ZKKh+fZYC5rOufsWhtzto1Ba+P07k5xobClrBGglqXW0PENq9Rrakql96K5pd+TVTCYfK8Ss9
 0DhpbYn2BKq6VhsHEfabT96sE9nxWGvJmcmOn3+pZAyPWXNT6sy9IYObv9wbBMHi8zCMEsS6k
 iTDNSiQ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file *of,
>>  			break;
>>  		ctx.body += len;
>>  
>> -		ret = -EINVAL;
>>  		p = tok;
>>  		strsep(&p, "=");
>> -		if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max")))
>> +		if (!p || (sscanf(p, "%llu", &val) != 1 && strcmp(p, "max"))) {
>> +			ret = -EINVAL;
>>  			goto out_finish;
>> +		}
> 
> Sorry, I don't like this patch. We know the next error if we encounter one
> will be EINVAL until we change it.

Thanks for your constructive feedback.


> Your patch doesn't introduce a functual change and doesn't improve readability,
> so I don't really see a point for it.

We have got different preferences for the placement of error code settings.
Do you care about run time changes there?

Regards,
Markus